Skip to content

Commit 2a174d8

Browse files
authored
Fix python sandbox parameters (#191)
1 parent a656bab commit 2a174d8

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

py/src/braintrust/cli/push.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from .. import api_conn, login, org_id, proxy_conn
2323
from ..framework2 import ProjectIdCache, global_
2424
from ..generated_types import IfExists
25-
from ..parameters import parameters_to_json_schema
25+
from ..parameters import serialize_remote_eval_parameters_container
2626
from ..util import add_azure_blob_headers
2727

2828

@@ -289,7 +289,7 @@ def _collect_evaluator_defs(
289289
scores = [{"name": _scorer_name(scorer, i)} for i, scorer in enumerate(evaluator.scores)]
290290
evaluator_definition: dict[str, Any] = {"scores": scores}
291291
if evaluator.parameters is not None:
292-
evaluator_definition["parameters"] = parameters_to_json_schema(evaluator.parameters)
292+
evaluator_definition["parameters"] = serialize_remote_eval_parameters_container(evaluator.parameters)
293293

294294
functions.append(
295295
{

py/src/braintrust/cli/test_push_evaluator.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,8 +92,11 @@ def test_evaluator_with_parameters(self, mock_project_ids):
9292
_collect_evaluator_defs(mock_project_ids, functions, "bundle-1", "replace", "eval.py", evaluators)
9393

9494
eval_def = functions[0]["function_data"]["data"]["location"]["evaluator_definition"]
95-
assert "parameters" in eval_def
9695
assert "scores" in eval_def
96+
parameters = eval_def["parameters"]
97+
assert parameters["type"] == "braintrust.staticParameters"
98+
assert parameters["source"] is None
99+
assert parameters["schema"]["prompt"]["type"] == "prompt"
97100

98101
def test_slug_from_source_file(self, mock_project_ids):
99102
evaluators = {"Test Eval": _make_evaluator("test-project", ["accuracy"])}

0 commit comments

Comments
 (0)