Filter unpopular mirrors

Author: pierres

api/src/Repository/MirrorRepository.php

@@ -14,6 +14,8 @@
  */
 class MirrorRepository extends ServiceEntityRepository
 {
+    public const int MIN_POPULARITY = 5;
+
     public function __construct(ManagerRegistry $registry)
     {
         parent::__construct($registry, Mirror::class);
@@ -29,15 +31,19 @@ public function getCountByUrlAndRange(string $url, int $startMonth, int $endMont
             $queryBuilder
                 ->select('mirror.count')
                 ->andWhere('mirror.month = :month')
-                ->setParameter('month', $startMonth);
+                ->setParameter('month', $startMonth)
+                ->andWhere('mirror.count >= :minPopularity')
+                ->setParameter('minPopularity', self::MIN_POPULARITY);
         } else {
             $queryBuilder
-                ->select('SUM(mirror.count)')
+                ->select('SUM(mirror.count) AS mirror_count')
                 ->andWhere('mirror.month >= :startMonth')
                 ->andWhere('mirror.month <= :endMonth')
                 ->groupBy('mirror.url')
                 ->setParameter('startMonth', $startMonth)
-                ->setParameter('endMonth', $endMonth);
+                ->setParameter('endMonth', $endMonth)
+                ->having('mirror_count >= :minPopularity')
+                ->setParameter('minPopularity', self::MIN_POPULARITY);
         }
 
         try {

api/tests/Controller/ApiMirrorsControllerTest.php

@@ -4,6 +4,7 @@
 
 use App\Controller\ApiMirrorsController;
 use App\Entity\Mirror;
+use App\Repository\MirrorRepository;
 use PHPUnit\Framework\Attributes\CoversClass;
 use PHPUnit\Framework\Attributes\DataProvider;
 use Symfony\Component\HttpFoundation\Response;
@@ -16,8 +17,7 @@ class ApiMirrorsControllerTest extends DatabaseTestCase
     public function testFetchAllMirrors(string $mirrorUrl): void
     {
         $entityManager = $this->getEntityManager();
-        $mirror = new Mirror($mirrorUrl)
-            ->setMonth((int)new \DateTime()->format('Ym'));
+        $mirror = $this->createPopularMirror($mirrorUrl, (int)new \DateTime()->format('Ym'));
         $entityManager->persist($mirror);
         $entityManager->flush();
 
@@ -217,6 +217,17 @@ public function testMirrorsSeries(string $mirrorUrl): void
         $this->assertEquals($mirrorUrl, $popularityList['mirrorPopularities'][0]['url']);
     }
 
+    private function createPopularMirror(string $url, int $month): Mirror
+    {
+        $mirror = new Mirror($url)
+            ->setMonth($month);
+        for ($i = 1; $i < MirrorRepository::MIN_POPULARITY; $i++) {
+            $mirror->incrementCount();
+        }
+
+        return $mirror;
+    }
+
     /**
      * @return list<string[]>
      */