Skip to content

Commit a13a246

Browse files
mini666juke-mini666
authored andcommitted
HBASE-30033 Add tests for setFilter() batch validation
- testSetFilterWithBatchThrows: setBatch() then setFilter(PageFilter) should throw IncompatibleFilterException - testSetFilterWithoutBatchDoesNotThrow: setFilter(PageFilter) without batch should succeed - testSetFilterWithBatchAndNonFilterRowFilter: setBatch() then setFilter(FilterList) should succeed since FilterList.hasFilterRow() returns false
1 parent 7799204 commit a13a246

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

  • hbase-client/src/test/java/org/apache/hadoop/hbase/client

hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestScan.java

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,8 @@
2929
import org.apache.hadoop.hbase.HConstants;
3030
import org.apache.hadoop.hbase.client.Scan.ReadType;
3131
import org.apache.hadoop.hbase.filter.FilterList;
32+
import org.apache.hadoop.hbase.filter.IncompatibleFilterException;
33+
import org.apache.hadoop.hbase.filter.PageFilter;
3234
import org.apache.hadoop.hbase.security.access.Permission;
3335
import org.apache.hadoop.hbase.security.visibility.Authorizations;
3436
import org.apache.hadoop.hbase.testclassification.ClientTests;
@@ -260,6 +262,28 @@ public void testScanCopyConstructor() throws Exception {
260262
EqualsBuilder.reflectionEquals(scan, scanCopy));
261263
}
262264

265+
@Test(expected = IncompatibleFilterException.class)
266+
public void testSetFilterWithBatchThrows() {
267+
Scan scan = new Scan();
268+
scan.setBatch(5);
269+
scan.setFilter(new PageFilter(10));
270+
}
271+
272+
@Test
273+
public void testSetFilterWithoutBatchDoesNotThrow() {
274+
Scan scan = new Scan();
275+
scan.setFilter(new PageFilter(10));
276+
// no exception expected
277+
}
278+
279+
@Test
280+
public void testSetFilterWithBatchAndNonFilterRowFilter() {
281+
Scan scan = new Scan();
282+
scan.setBatch(5);
283+
scan.setFilter(new FilterList());
284+
// FilterList.hasFilterRow() returns false, so no exception expected
285+
}
286+
263287
@Test
264288
public void testScanReadType() throws Exception {
265289
Scan scan = new Scan();

0 commit comments

Comments
 (0)