Skip to content

Add proper module name in Manifest #731

@blacelle

Description

@blacelle

Hello,

Any plan to add proper jpms/JDK9 module configuration into the library?

Current manifest looks like :

Manifest-Version: 1.0
Build-Jdk-Spec: 25
Build-OS: Mac OS X aarch64 26.1
Build-Tool-Jdk-Spec: 25
GroupId-ArtifactId: org.apache.datasketches:datasketches-java
Implementation-Vendor: The Apache Software Foundation
git-branch: 9.0.X
git-commit-id: f3b334b380feee9f928500de9adb6bbf763fc104
git-commit-tag: 9.0.0-RC1
git-commit-time: 
git-commit-user-email: xxx@yyy.com

An easy way forward would be through an additional Automatic-Module-Name entry, like:

Automatic-Module-Name: org.apache.datasketches

it can be done with something like:

<plugin>
	<groupId>org.apache.maven.plugins</groupId>
	<artifactId>maven-jar-plugin</artifactId>
	<configuration>
		<archive>
			<manifestEntries>
				<Automatic-Module-Name>org.apache.datasketches</Automatic-Module-Name>
			</manifestEntries>
		</archive>
	</configuration>
</plugin>

edit: I would benefit from this going from datasketches 7.X

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions