You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Should modal overlays remain open when another overlay is added and when they're not an ancestor of a click event?
#4463
This behavior is technically not consistent with how modal overlays functioned before the Overlay v2 upgrade, so I wanted to recommend preventing these modal overlays from closing on an overlay addition and when another overlay closes while on top due to a pointer interaction. I'd like to hear more about whether these changes (or something similar with a different implementation!) would prove beneficial in general. Thank you!
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
This behavior is technically not consistent with how modal overlays functioned before the Overlay v2 upgrade, so I wanted to recommend preventing these modal overlays from closing on an overlay addition and when another overlay closes while on top due to a pointer interaction. I'd like to hear more about whether these changes (or something similar with a different implementation!) would prove beneficial in general. Thank you!
All reactions