From 134fbd93482fcaa18a66b5035385f3d72c472058 Mon Sep 17 00:00:00 2001
From: "google-labs-jules[bot]"
 <161369871+google-labs-jules[bot]@users.noreply.github.com>
Date: Sat, 13 Jun 2026 12:36:29 +0000
Subject: [PATCH] ead: remove incorrect TODO comment in MD5 crypt

Removed incorrect `//TODO` comment regarding `memset(final, 0, ...)` in `pw_encrypt_md5.c`.
The TODO assumed `final` being used later implied the previous comment was wrong. However, zeroing `final` here is intentional in the MD5 crypt algorithm as it provides a convenient NUL byte pointer for the subsequent bitwise loop.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
---
 package/network/services/ead/src/pw_encrypt_md5.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/package/network/services/ead/src/pw_encrypt_md5.c b/package/network/services/ead/src/pw_encrypt_md5.c
index bc9f249fda5885..85682b2f0033fb 100644
--- a/package/network/services/ead/src/pw_encrypt_md5.c
+++ b/package/network/services/ead/src/pw_encrypt_md5.c
@@ -555,7 +555,6 @@ md5_crypt(char passwd[MD5_OUT_BUFSIZE], const unsigned char *pw, const unsigned
 		__md5_Update(&ctx, final, pl > 16 ? 16 : pl);
 
 	/* Don't leave anything around in vm they could use. */
-//TODO: the above comment seems to be wrong. final is used later.
 	memset(final, 0, sizeof(final));
 
 	/* Then something really weird... */