Revert "Maybe this did something?"

This reverts commit 1926a9c.

Author: kjy5

Assets/Scripts/Models/Scene/SceneReducers.cs

@@ -11,8 +11,8 @@ namespace Models.Scene
     [Serializable]
     public record SceneState
     {
-        public ProbeState[] Probes = Array.Empty<ProbeState>();
-        public ManipulatorState[] Manipulators = Array.Empty<ManipulatorState>();
+        public List<ProbeState> Probes = new();
+        public List<ManipulatorState> Manipulators = new();
 
         #region Active Probe
 
@@ -24,7 +24,7 @@ public record SceneState
             Probes.FirstOrDefault(state => state.Name == ActiveProbeName);
 
         // Helper to get the active probe index.
-        public int ActiveProbeIndex => Array.IndexOf(Probes, ActiveProbeState);
+        public int ActiveProbeIndex => Probes.IndexOf(ActiveProbeState);
 
         #endregion
 
@@ -38,7 +38,7 @@ public record SceneState
             Manipulators.FirstOrDefault(state => state.Id == ActiveManipulatorId);
 
         // Helper to get the active probe index.
-        public int ActiveManipulatorIndex => Array.IndexOf(Manipulators, ActiveManipulatorState);
+        public int ActiveManipulatorIndex => Manipulators.IndexOf(ActiveManipulatorState);
 
         #endregion
 

Assets/Scripts/Models/Scene/SceneState.cs

@@ -676,7 +676,7 @@ public void DragMovementClick()
         var startingProbeState = startingSceneState.Probes.FirstOrDefault(state => state.Name == name);
 
         if (EventSystem.current.IsPointerOverGameObject() || startingProbeState == null ||
-            startingSceneState.Manipulators.Any(state => state.VisualizationProbeName == name) ||
+            startingSceneState.Manipulators.Exists(state => state.VisualizationProbeName == name) ||
             startingProbeState.Locked) return;
 #else
         if (EventSystem.current.IsPointerOverGameObject() || ProbeManager.IsEphysLinkControlled || UnlockedDir != Vector4.one)
@@ -738,7 +738,7 @@ public void DragMovementDrag()
 
         // Exit if there is no state.
         if (currentProbeState == null ||
-            currentSceneState.Manipulators.Any(state => state.VisualizationProbeName == name) ||
+            currentSceneState.Manipulators.Exists(state => state.VisualizationProbeName == name) ||
             currentProbeState.Locked) return;
 #else
         if (ProbeManager.IsEphysLinkControlled || UnlockedDir != Vector4.one)

Assets/Scripts/Pinpoint/Probes/Controllers/CartesianProbeController.cs

@@ -669,7 +669,7 @@ public void DragMovementClick()
         var startingProbeState = startingSceneState.Probes.FirstOrDefault(state => state.Name == name);
 
         if (EventSystem.current.IsPointerOverGameObject() || startingProbeState == null ||
-            startingSceneState.Manipulators.Any(state => state.VisualizationProbeName == name) ||
+            startingSceneState.Manipulators.Exists(state => state.VisualizationProbeName == name) ||
             startingProbeState.Locked) return;
 #else
         if (EventSystem.current.IsPointerOverGameObject() || ProbeManager.IsEphysLinkControlled || UnlockedDir != Vector4.one)
@@ -731,7 +731,7 @@ public void DragMovementDrag()
 
         // Exit if there is no state.
         if (currentProbeState == null ||
-            currentSceneState.Manipulators.Any(state => state.VisualizationProbeName == name) ||
+            currentSceneState.Manipulators.Exists(state => state.VisualizationProbeName == name) ||
             currentProbeState.Locked) return;
 #else
         if (ProbeManager.IsEphysLinkControlled || UnlockedDir != Vector4.one)

Assets/Scripts/Pinpoint/Probes/Controllers/SagittalCoronalProbeController.cs

@@ -1,4 +1,3 @@
-using System.Linq;
 using Models;
 using Models.Scene;
 using Models.Settings;
@@ -89,7 +88,7 @@ private void OnProbeWorldStateChanged(ProbeWorldState probeWorldState)
             // Update color to match probe color - need to get from SceneState
             var storeService = PinpointApp.Services.GetRequiredService<StoreService>();
             var sceneState = storeService.Store.GetState<SceneState>(SliceNames.SCENE_SLICE);
-            var probeState = sceneState.Probes.FirstOrDefault(p => p.Name == _activeProbeWorldStateName);
+            var probeState = sceneState.Probes.Find(p => p.Name == _activeProbeWorldStateName);
 
             if (probeState != null)
             {

Assets/Scripts/Pinpoint/Probes/SurfaceCoordinate.cs

@@ -1,5 +1,4 @@
 using System;
-using System.Linq;
 using System.Threading.Tasks;
 using TMPro;
 using UnityEngine;
@@ -91,7 +90,7 @@ private void Start()
          state =>
    {
    var sceneState = state.Get<SceneState>(SliceNames.SCENE_SLICE);
-         return sceneState.Probes.FirstOrDefault(p => p.Name == sceneState.ActiveProbeName);
+         return sceneState.Probes.Find(p => p.Name == sceneState.ActiveProbeName);
      },
      probeState =>
         {

Assets/Scripts/Pinpoint/TP_InPlaneSlice.cs

@@ -38,7 +38,7 @@ public ProbeListItemViewModel(ProbeState probeState, StoreService storeService)
 
             IsVisualizationProbe = storeService
                 .Store.GetState<SceneState>(SliceNames.SCENE_SLICE)
-                .Manipulators.Any(state => state.VisualizationProbeName == probeState.Name);
+                .Manipulators.Exists(state => state.VisualizationProbeName == probeState.Name);
             Color = _probeState.Color;
             Name = _probeState.Name;
             Hidden = _probeState.ProbeDisplayType == ProbeDisplayType.Line;

Assets/Scripts/UI/ViewModels/ProbeListItemViewModel.cs

@@ -147,10 +147,10 @@ private void HandleActiveProbeChange(string newActiveProbeName)
         /// <summary>
         /// Check if any probe positions or angles have changed and trigger collision detection if so
         /// </summary>
-        private void CheckForProbeMovement(ProbeState[] currentProbeStates)
+        private void CheckForProbeMovement(List<ProbeState> currentProbeStates)
         {
             // If this is the first time or probe count changed, just update the cache
-            if (_previousProbeStates.Count != currentProbeStates.Length)
+            if (_previousProbeStates.Count != currentProbeStates.Count)
             {
                 _previousProbeStates = currentProbeStates.Select(p => p).ToList();
                 ColliderManager.CheckForCollisions();
@@ -159,7 +159,7 @@ private void CheckForProbeMovement(ProbeState[] currentProbeStates)
 
             // Check if any probe's position or angles have changed
             bool probesMoved = false;
-            for (int i = 0; i < currentProbeStates.Length; i++)
+            for (int i = 0; i < currentProbeStates.Count; i++)
             {
                 var current = currentProbeStates[i];
                 var previous = _previousProbeStates.FirstOrDefault(p => p.Name == current.Name);