Fix: remove {{PAGENAME}} variants from error page

TrueBrain · TrueBrain · commit 99a63deb8d4d · 2020-11-14T13:31:53.000+01:00
With this, you could escape the wikitext and insert your own text.
Validation on the Page name would fail, but as the error page would
render it as text, it would be shown to the user. This is unwanted,
and as such, we now no longer print it.
diff --git a/templates/Error.mediawiki b/templates/Error.mediawiki
@@ -5,40 +5,25 @@
         <link rel="icon" href="/static/favicon.ico" type="image/icon" />
         <link rel="stylesheet" href="/static/css/base.css" type="text/css" />
         <link rel="stylesheet" href="/static/css/truewiki.css" type="text/css" />
-        <title>OpenTTD | {{SUBPAGENAME}}</title>
+        <title>OpenTTD | Error</title>
     </head>
     <body>
         <header>
             <div id="pagename">
-                {{SUBPAGENAME}}
+                Error
             </div>
             <div id="openttd-logo">
                 <div id="openttd-logo-text"><a href="/en/"><img src="/static/img/layout/openttd-logo.png" alt="OpenTTD" /></a></div>
             </div>
-            {{#if: {{{user_settings_url}}}|
-            <div id="review-access">
-                <a href="{{{user_settings_url}}}">Review access</a>
-            </div>
-            }}
         </header>
         <nav>
             <ul id="navigation-bar">
                 {{breadcrumbs}}
             </ul>
             <ul id="navigation-bar" class="right">
-                {{#if: {{{display_name|}}}|
-                <li>
-                    <a href="/user/logout?location={{urlencode:{{FULLPAGENAME}}}}">Logout ({{{display_name}}})</a>
-                </li>
-                |
-                <li>
-                    <a href="/user/login?location={{urlencode:{{FULLPAGENAME}}}}">Login</a>
-                </li>
-                }}
             </ul>
         </nav>
         <main>
-            <h2>Error</h2>
             {{content}}
         </main>
         <footer>
