Fix multiprocessing deadlock and parallelize directory walk in 01_scanDicom.py#13
Conversation
…nDicom.py * Removes `logger` from worker function arguments to prevent lock-pickling deadlocks when using `run_function` in multiprocess mode. * Replaces the serial `os.walk` in `_scan_subdir` with a BFS approach to yield disjoint branch directories for parallel worker consumption, drastically speeding up initial file discovery in deep hierarchies. * Fixes failing unit tests referencing the updated function signatures. Co-authored-by: NicholasLeotta99 <32443489+NicholasLeotta99@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This commit resolves GitHub CI Check Suite Failures by updating the `test_scanDicom_full.py` tests. The function signatures for `_find_dicom_worker` and `_extractDicom_impl` had their `logger` arguments removed in a previous commit to resolve a lock-pickling deadlock during multiprocessing. However, the full test suite had not been updated to reflect these signature changes. This commit updates those function calls across the full suite, allowing all 32 tests to correctly pass. Co-authored-by: NicholasLeotta99 <32443489+NicholasLeotta99@users.noreply.github.com>
NicholasLeotta99
deleted the
fix-01-scan-dicom-parallel-deadlock-18142721776499537583
branch
1 participant
Fix multiprocessing deadlock and parallelize directory walk in 01_scanDicom.py
loggerfrom worker function arguments to prevent lock-pickling deadlocks when usingrun_functionin multiprocess mode.os.walkin_scan_subdirwith a BFS approach to yield disjoint branch directories for parallel worker consumption, drastically speeding up initial file discovery in deep hierarchies.PR created automatically by Jules for task 18142721776499537583 started by @NicholasLeotta99