Wrong info when character is not disconnected and another tries to log in

[mtwango]

When player logs out character, which stays ingame and tries to log another character, wrong message is displayed on the client.

This is probably due to sending 2 info packets, which client handles wrong here:

Source-X/src/game/clients/CClientMsg.cpp

Line 2932 in 92ced0b

addIdleWarning(PacketWarningMessage::CharacterInWorld);

[Jhobean]

I confirm this issue. So many player on my shard see that. They become white and want cry... It's a inside joke when player complain about that on discord🤣.

Edit. I'm with Orion. Maybe it's client bug

[Jhobean]

After reading the Cliloc

It should be cliloc 12 instead

[mtwango]

Classic UO messages: https://github.com/ClassicUO/ClassicUO/blob/5534d938d667ec8c74530c2af34ee04ba7104328/src/ClassicUO.Client/Game/Data/ServerErrorMessages.cs#L9

Its seems to be defined ok, but the 2 packets seems to wire it wrong

[Jhobean]

After some test on my side with Gemini (Because it's was too tricky for me) here what the conclusion we have.

I tested it and it seem to work fine but Maybe I forgot some situation. Check the PR #1579

The Problem
Sphere was using generic or mismatched error codes when a character login failed. This led to two specific issues:

1. Linger Conflict: Players switching characters saw "This character does not exist anymore" instead of "Another
   character is online."
2. Generic Errors: If a character was actually missing (deleted), the server sent a generic "Could not attach to
   server" message, which was unhelpful for troubleshooting.

The Logic Behind the Remapping
To fix this, we synchronized Sphere’s internal error states with the client's Cliloc (localized string) indices. We
categorized failures into two distinct paths:

1. The "Still Online" Path (CharIdle)

• Context: The character exists and is valid, but the previous session is still "lingering" in the world.
• Old Behavior: Mapped to Code 1, which triggered the wrong message ("Does not exist").
• New Behavior: Mapped to Code 5 (triggers Cliloc 3000012: "Another character from this account is currently
  online").
• Result: Accurate feedback; the player knows they just need to wait a few seconds for the linger time to expire.

2. The "Truly Missing" Path (BadCharacter)

• Context: The client requests a character slot or UID that the server cannot find (e.g., the character was deleted
  while the player was on the selection screen).
• Old Behavior: Mapped to Code 4 (triggers Cliloc 3000017: "The client could not attach to the game server"). This
  generic message misled players into thinking the server was down.
• New Behavior: Mapped to Code 1 (triggers Cliloc 3000009: "This character does not exist anymore. You will have to
  recreate it").
• Result: Precise feedback; the player is correctly informed that the specific character is gone, rather than
  thinking it's a network/server issue.

Summary of Changes

• src/network/send.h: Adjusted the PacketWarningMessage enum to ensure CharacterInWorld equals 0x05 to align with the
  client-side Cliloc 3000012.
• src/game/clients/CClientLog.cpp: Updated the addLoginErr translation logic:
  • Redirected CharIdle to Code 5 (Specific "Already Online" message).
  • Redirected BadCharacter to Code 1 (Specific "Does not exist" message).

Outcome
The server now provides state-specific feedback. It no longer tells players their character is "missing" when it's
actually "lingering," and it no longer gives a "server error" when a character is actually "missing."