SONARJAVA-6205 Remove reflection to load DBD rule keys

DBD registers rules using ProfileRegistrar defined in the sonar-java API
and is therefore automatically loaded into all built-in quality
profiles.

Author: dorian-burihabwa-sonarsource

sonar-java-plugin/src/main/java/org/sonar/plugins/java/BuiltInJavaQualityProfile.java

@@ -41,10 +41,8 @@ abstract class BuiltInJavaQualityProfile implements BuiltInQualityProfilesDefini
   static final String SECURITY_RULES_CLASS_NAME = "com.sonar.plugins.security.api.JavaRules";
   static final String DBD_RULES_CLASS_NAME = "com.sonarsource.plugins.dbd.api.JavaRules";
   static final String SECURITY_RULE_KEYS_METHOD_NAME = "getSecurityRuleKeys";
-  static final String DBD_RULE_KEYS_METHOD_NAME = "getDataflowBugDetectionRuleKeys";
   static final String GET_REPOSITORY_KEY = "getRepositoryKey";
   static final String SECURITY_REPOSITORY_KEY = "javasecurity";
-  static final String DBD_REPOSITORY_KEY = "javabugs";
 
 
   protected final ProfileRegistrar[] profileRegistrars;
@@ -74,9 +72,6 @@ public void define(Context context) {
     if (ruleKeys.stream().noneMatch(rule -> SECURITY_REPOSITORY_KEY.equals(rule.repository()))) {
       ruleKeys.addAll(getSecurityRuleKeys());
     }
-    if (ruleKeys.stream().noneMatch(rule -> DBD_REPOSITORY_KEY.equals(rule.repository()))) {
-      ruleKeys.addAll(getDataflowBugDetectionRuleKeys());
-    }
 
     ruleKeys.forEach(ruleKey -> profile.activateRule(ruleKey.repository(), ruleKey.rule()));
     profile.setDefault(isDefault());
@@ -105,11 +100,6 @@ Set<RuleKey> getSecurityRuleKeys() {
     return getExternalRuleKeys(SECURITY_RULES_CLASS_NAME, SECURITY_RULE_KEYS_METHOD_NAME, "security");
   }
 
-  @VisibleForTesting
-  Set<RuleKey> getDataflowBugDetectionRuleKeys() {
-    return getExternalRuleKeys(DBD_RULES_CLASS_NAME, DBD_RULE_KEYS_METHOD_NAME, "dataflow bug detection");
-  }
-
   @VisibleForTesting
   Set<RuleKey> getExternalRuleKeys(String className, String ruleKeysMethod, String rulesCategory) {
     try {

sonar-java-plugin/src/test/java/org/sonar/plugins/java/JavaSonarWayProfileTest.java

@@ -103,17 +103,6 @@ void should_contains_security_rules_if_present() {
     assertThat(new JavaSonarWayProfile().getSecurityRuleKeys()).containsOnly(RuleKey.of("security-repo-key", "S3649"));
   }
 
-  @Test
-  void should_contains_dataflow_bug_detection_rules_if_present() {
-    // no dataflow bug detection rules available
-    com.sonarsource.plugins.dbd.api.JavaRules.ruleKeys = new HashSet<>();
-    assertThat(new JavaSonarWayProfile().getDataflowBugDetectionRuleKeys()).isEmpty();
-
-    // one dataflow bug detection rule available
-    com.sonarsource.plugins.dbd.api.JavaRules.ruleKeys = new HashSet<>(Arrays.asList("S6322"));
-    assertThat(new JavaSonarWayProfile().getDataflowBugDetectionRuleKeys()).containsOnly(RuleKey.of("dbd-repo-key", "S6322"));
-  }
-
   @Test
   void external_rule_keys_missing_class() {
     new JavaSonarWayProfile().getExternalRuleKeys("silly.name", "getDataflowBugDetectionRuleKeys", "ruleCategory");