Fix infinite render loop by guaranteeing layout commit

Author: pythonsst

src/recyclerview/RecyclerView.tsx

@@ -93,6 +93,10 @@ const RecyclerViewComponent = <T,>(
 
   renderTimeTracker.startTracking();
 
+  const layoutRetryCountRef = useRef(0);
+  const MAX_LAYOUT_RETRIES = 5;
+
+
   // Sticky header config
   const stickyHeaderOffset = stickyHeaderConfig?.offset ?? 0;
   const stickyHeaderUseNativeDriver =
@@ -183,7 +187,7 @@ const RecyclerViewComponent = <T,>(
         },
         isHorizontalRTL && recyclerViewManager.hasLayout()
           ? firstItemOffset -
-              recyclerViewManager.getChildContainerDimensions().width
+          recyclerViewManager.getChildContainerDimensions().width
           : firstItemOffset
       );
     }
@@ -227,17 +231,42 @@ const RecyclerViewComponent = <T,>(
       console.warn(WarningMessages.exceededMaxRendersWithoutCommit);
     }
 
-    if (
-      recyclerViewManager.modifyChildrenLayout(layoutInfo, data?.length ?? 0) &&
-      !hasExceededMaxRendersWithoutCommit
-    ) {
-      // Trigger re-render if layout modifications were made
-      setRenderId((prev) => prev + 1);
+    // if (
+    //   recyclerViewManager.modifyChildrenLayout(layoutInfo, data?.length ?? 0) &&
+    //   !hasExceededMaxRendersWithoutCommit
+    // ) {
+    //   // Trigger re-render if layout modifications were made
+    //   setRenderId((prev) => prev + 1);
+    // } else {
+    //   viewHolderCollectionRef.current?.commitLayout();
+    //   applyOffsetCorrection();
+    // }
+
+    const layoutChanged = recyclerViewManager.modifyChildrenLayout(
+      layoutInfo,
+      data?.length ?? 0
+    );
+
+    if (layoutChanged && !hasExceededMaxRendersWithoutCommit) {
+      layoutRetryCountRef.current += 1;
+
+      if (layoutRetryCountRef.current <= MAX_LAYOUT_RETRIES) {
+        // Allow a few retries to stabilize layout
+        setRenderId((prev) => prev + 1);
+      } else {
+        // Force convergence: commit layout and reset
+        layoutRetryCountRef.current = 0;
+        viewHolderCollectionRef.current?.commitLayout();
+        applyOffsetCorrection();
+      }
     } else {
+      // Layout is stable
+      layoutRetryCountRef.current = 0;
       viewHolderCollectionRef.current?.commitLayout();
       applyOffsetCorrection();
     }
 
+
     if (
       horizontal &&
       recyclerViewManager.hasLayout() &&
@@ -585,8 +614,8 @@ const RecyclerViewComponent = <T,>(
               return Math.max(
                 0,
                 windowSize -
-                  childContainerSize -
-                  recyclerViewManager.firstItemOffset
+                childContainerSize -
+                recyclerViewManager.firstItemOffset
               );
             }}
             refHolder={refHolder}