Skip to content

Update the pipeline figure in example (and example) #143

Description

@CasperWA

Please update the below figure. The filter strategy should come after the data resource strategy in the pipeline:

image

This is conceptually important. We have the partial pipeline documenting the data source (typically DataResource >> Parse >> Mapping). That should be treated as one unit and always come first in the pipeline. The filter is not a part of the documentation of the data resource, but is a part of our application that selects the subset of all the data in the data resource we are interested in. It should use the initialize() method to specify the query such that only the information we need is fetched from the data resource.

I did this originally, but unfortunately the session object is not returned correctly from the "filter strategy", so I had to switch them around. I believe this issue is being resolved in OTElib, but this is an issue.
Furthermore, retrieving the data from the session object is plain wrong and should not be done like this. But that's out-of-scope of this tutorial to fix.

Originally posted by @CasperWA in #125 (comment)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions