Skip to content

Incompatible with maintained drop-in replacement for shanecurran/phpecc #15

@dsbaars

Description

@dsbaars

This library makes use of https://github.com/shanecurran/phpecc which hasn't been actively maintained for almost 3 years.

We are using https://github.com/paragonie/phpecc which is a maintained drop-in replacement.
This worked fine until the most recent version v2.5.0 where they added a getSignatureType() method to \Mdanter\Ecc\Crypto\Signature\SignatureInterface which BitWasp\Bitcoin\Crypto\EcAdapter\Impl\PhpEcc\Signature implements.

This results in a fatal error when upgrading. As the signature type is always ecdsa an implementation is simple.
I will submit a pull request with the added method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions