Skip to content

Commit c5824e4

Browse files
TravisEz13Copilot
andauthored
Exclude .vscode-test/** from OneBranch SDL/CodeQL scans (#5457)
* Exclude .vscode-test/** from OneBranch SDL/CodeQL scans The @vscode/test-electron package downloads VS Code Insiders binaries into .vscode-test/ at test time for extension integration tests. This directory is already in .gitignore but is present on disk when the OneBranch async SDL scanner runs after 'Invoke-Build Test'. The CodeQL SM04514 'Weak hashes' alert (S360/ADO #35101062) fires against VS Code's own cliProcessMain.js inside this directory — code that the PowerShell team has no ownership of or ability to fix. Adding ob_sdl_codeql_pathsToExclude prevents future false-positive alerts from third-party VS Code binary artifacts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Update comment for CodeQL scan exclusions Clarified comment regarding exclusion of VS Code test binaries from CodeQL scans. --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
1 parent bd33d21 commit c5824e4

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

.pipelines/vscode-powershell-OneBranch.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ extends:
7070
variables:
7171
ob_outputDirectory: $(Build.SourcesDirectory)/out
7272
ob_sdl_codeSignValidation_excludes: -|**\*.js # Node.js JavaScript signatures are not supported
73+
# Exclude downloaded VS Code test binaries from CodeQL scans.
74+
# .vscode-test/ is populated at test-time by @vscode/test-electron with VS Code
75+
# Insiders binaries; it is already .gitignore'd but is present during SDL scans.
76+
ob_sdl_codeql_pathsToExclude: .vscode-test/**
7377
steps:
7478
- pwsh: |
7579
$version = (Get-Content -Raw -Path package.json | ConvertFrom-Json).version

0 commit comments

Comments
 (0)