Dead code in PL IR: unused fold_func_param, write-only prev_columns, unreachable display_ids

[prql-bot]

The nightly survey (2026-04-12) identified several pieces of dead code in the PL IR and related modules. These are structural enough that they may warrant maintainer review before removal.

1. fold_func_param is never called

fold.rs:289 exports fold_func_param but it has zero callers. The default fold_func implementation uses struct spread and only folds body and args, skipping FuncParam::default_value and Func::env. This means all PlFold implementors miss expressions within default parameter values and captured environments.

This could be a latent correctness issue if any fold pass needs to visit those fields, or it could be intentional if those fields are always resolved before folding occurs.

2. Lineage::prev_columns is write-only

lineage.rs:21 defines prev_columns which is populated by Lineage::clear() but never read anywhere. The comment says it is "A hack that allows name retention when applying ExprKind::All { except }", but no code reads it. It is also #[serde(skip)].

3. display_ids parameter is always false

lineage.rs:74 display_lineage accepts display_ids: bool but the only call site always passes false, making the true branch unreachable. Appears to be an unfinished debugging aid.

[prql-bot]

I verified all three findings against the current codebase:

1. fold_func_param (fold.rs:289) — confirmed zero callers. The default fold_func at line 271 folds body and args via struct spread but never calls fold_func_param for params or named_params. Worth noting: if a fold pass ever needs to visit FuncParam::default_value, this function would be the right vehicle — so this is either dead code to remove or a missing call in fold_func.

2. Lineage::prev_columns (lineage.rs:21) — confirmed write-only. Lineage::clear() at transforms.rs:830-831 moves columns into prev_columns, but nothing reads prev_columns afterward. The comment mentions ExprKind::All { except } but the read side was never implemented or was removed.

3. display_ids (lineage.rs:74) — confirmed. The sole call site at line 70 always passes false, making the true branch unreachable.

All three are safe to remove individually. Item 1 has a subtlety — removing it is straightforward, but the underlying question (should fold_func visit default values and env?) may be worth a quick check before closing. Items 2 and 3 are clean removals with no behavioral impact.

Leaving for a maintainer to decide on scope.