[WIP] Preserve implicitly active state when saving load order

Don't record implicitly active plugins as explicitly active when saving the load order.

WIP because there's a failing test, and I'm not sure this is a
beneficial change overall.

Author: Ortham

src/load_order/asterisk_based.rs

@@ -154,7 +154,7 @@ impl WritableLoadOrder for AsteriskBasedLoadOrder {
                 continue;
             }
 
-            if plugin.is_active() {
+            if plugin.is_explicitly_active() {
                 write!(writer, "*").map_err(|e| Error::IoError(path.clone(), e))?;
             }
             writer

src/load_order/openmw.rs

@@ -261,7 +261,11 @@ impl WritableLoadOrder for OpenMWLoadOrder {
             .collect();
 
         let cfg_path = self.game_settings.active_plugins_file();
-        write_openmw_cfg(cfg_path, &data_paths, &self.active_plugin_names())?;
+        write_openmw_cfg(
+            cfg_path,
+            &data_paths,
+            &self.explicitly_active_plugin_names(),
+        )?;
 
         Ok(())
     }

src/load_order/readable.rs

@@ -34,6 +34,14 @@ pub trait ReadableLoadOrderBase {
             .enumerate()
             .find(|(_, p)| p.name_matches(plugin_name))
     }
+
+    fn explicitly_active_plugin_names(&self) -> Vec<&str> {
+        self.plugins()
+            .iter()
+            .filter(|p| p.is_explicitly_active())
+            .map(Plugin::name)
+            .collect()
+    }
 }
 
 pub trait ReadableLoadOrder {

src/load_order/textfile_based.rs

@@ -86,7 +86,7 @@ impl TextfileBasedLoadOrder {
         let file = File::create(path).map_err(|e| Error::IoError(path.clone(), e))?;
         let mut writer = BufWriter::new(file);
 
-        for plugin_name in self.active_plugin_names() {
+        for plugin_name in self.explicitly_active_plugin_names() {
             writer
                 .write_all(&strict_encode(plugin_name)?)
                 .map_err(|e| Error::IoError(path.clone(), e))?;

src/load_order/timestamp_based.rs

@@ -88,7 +88,7 @@ impl TimestampBasedLoadOrder {
             .write_all(&prelude)
             .map_err(|e| Error::IoError(path.clone(), e))?;
 
-        for (index, plugin_name) in self.active_plugin_names().iter().enumerate() {
+        for (index, plugin_name) in self.explicitly_active_plugin_names().iter().enumerate() {
             if self.game_settings().id() == GameId::Morrowind {
                 write!(writer, "GameFile{index}=").map_err(|e| Error::IoError(path.clone(), e))?;
             }