Add optional ships_to_display field for vendors#155
Open
NanashiTheNameless wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an optional display override for “ships to” text in the vendor picker table so certain vendors can show custom shipping regions text instead of the derived region list.
Changes:
- Introduced optional
ships_to_displayfield onVendor. - Added
ships_to_displayfor at least one vendor entry. - Updated table rendering to prefer the override when present.
Comments suppressed due to low confidence (1)
src/components/vendor-picker.tsx:1
- This introduces duplicated, potentially divergent data (
fromcontains the same string asships_to_displayhere). If the intent is “ships to same region label as from”, consider deriving the display value at render time (or via a helper) instead of storing a second copy, to avoid future inconsistencies when one field changes and the other doesn’t.
"use client";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the way vendor shipping regions are displayed in the vendor picker component by adding an optional display field and updating the rendering logic to use it when available.
Display improvements:
ships_to_displayfield to theVendorinterface to allow for custom display text for shipping regions.ships_to_displayfield where appropriate (at least for myself).VendorTablerendering logic to showships_to_displayif present; otherwise, it falls back to the default region names.