Skip to content

Add optional ships_to_display field for vendors#155

Open
NanashiTheNameless wants to merge 2 commits into
OpenShock:masterfrom
NanashiTheNameless:master
Open

Add optional ships_to_display field for vendors#155
NanashiTheNameless wants to merge 2 commits into
OpenShock:masterfrom
NanashiTheNameless:master

Conversation

@NanashiTheNameless

Copy link
Copy Markdown
Contributor

This pull request enhances the way vendor shipping regions are displayed in the vendor picker component by adding an optional display field and updating the rendering logic to use it when available.

Display improvements:

  • Added an optional ships_to_display field to the Vendor interface to allow for custom display text for shipping regions.
  • Updated the vendor data entries to include the new ships_to_display field where appropriate (at least for myself).
  • Modified the VendorTable rendering logic to show ships_to_display if present; otherwise, it falls back to the default region names.

Copilot AI review requested due to automatic review settings June 8, 2026 10:33

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds an optional display override for “ships to” text in the vendor picker table so certain vendors can show custom shipping regions text instead of the derived region list.

Changes:

  • Introduced optional ships_to_display field on Vendor.
  • Added ships_to_display for at least one vendor entry.
  • Updated table rendering to prefer the override when present.
Comments suppressed due to low confidence (1)

src/components/vendor-picker.tsx:1

  • This introduces duplicated, potentially divergent data (from contains the same string as ships_to_display here). If the intent is “ships to same region label as from”, consider deriving the display value at render time (or via a helper) instead of storing a second copy, to avoid future inconsistencies when one field changes and the other doesn’t.
"use client";

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/vendor-picker.tsx
Comment thread src/components/vendor-picker.tsx Outdated
@NanashiTheNameless NanashiTheNameless marked this pull request as draft June 8, 2026 10:35
@NanashiTheNameless NanashiTheNameless marked this pull request as ready for review June 8, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants