Repository navigation
Step approvals: let a person's decision gate a Step #199
Replies: 2 comments
|
Great idea. One limitation of this current proposal is that the approval process must be handled by the scheduler and can't be handed over to another approval process. Someone might want approvals to be managed in a third party tool or project tracker. Variation: we could make the approval a special type of step to inherit existing step functionality.
Another variation: we could abstract this further to add a new type of step that runs asynchronously instead of synchronously on a worker. It could have onStart, onProgress (with a poll interval), and onExit scripts/handlers/commands. Couple examples:
^ this abstraction might obscure the approval idea though. An approval as a special construct means it can be labelled in a special way since it's not standard work. |
|
The request opens once PreviewFrames completes, but nothing in the proposal ties the approval to the preview the approver actually looked at, so if PreviewFrames gets requeued after the approval, FinalFrames can still run on frames nobody reviewed. I'd record the identity of the dependency outputs at decision time and have any re-run of a dependency put the approval back to pending, which also gives you the who-and-when record the gate-parameter workaround lacks. Is "only while an approval is in effect" meant to cover that case, or only expiry? |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Many pipelines have a point where a person, not a program, decides whether work continues: a supervisor reviews preview frames before a full-quality render on large GPU hosts, someone checks a sample of prepared training data before training, or a production confirms a third-party asset's license before a Job runs.
Open Job Description has no way to express this today. The usual workarounds each have a cost:
The idea
Add an optional
approvalproperty on a Step, behind a newSTEP_APPROVALSextension. A Step's Tasks may be scheduled only while an approval is in effect. The template says that a decision is needed and what the approver sees. The render management system decides who may decide, and how.A Step with an
approvaland noscriptis an approval-only Step: a review node in the Step graph with no Tasks and no Session. It completes when someone approves it, so the Steps that depend on it wait for the reviewer.Key points:
openjd runprompts at the gate, or takes--approve-step <Step>. With no terminal, an unapproved gate counts as rejected.Related: #80 (skip a Step via a parameter), #81 (
enableIf), #111 (passing values along Step dependencies).Tracking issue: #200. A full RFC draft is ready, and the PR will follow. I'd welcome early thoughts:
type: APPROVALStep?audience: budget, that a render management system maps to approvers?All reactions