fix: fallback to parentNode on removeChild (undocumented breaking change from angular/angular#57203)

edusperoni · edusperoni · commit a93c771eee38 · 2024-09-18T16:24:25.000-03:00
diff --git a/packages/angular/src/lib/nativescript-renderer.ts b/packages/angular/src/lib/nativescript-renderer.ts
@@ -268,7 +268,7 @@ class NativeScriptRenderer implements Renderer2 {
     if (NativeScriptDebug.enabled) {
       NativeScriptDebug.rendererLog(`NativeScriptRenderer.removeChild child: ${oldChild} parent: ${parent}`);
     }
-    this.viewUtil.removeChild(parent, oldChild);
+    this.viewUtil.removeChild(parent ?? oldChild.parentNode, oldChild);
   }
   selectRootElement(selectorOrNode: any, preserveContent?: boolean) {
     if (NativeScriptDebug.enabled) {

Original file line number	Diff line number	Diff line change
`@@ -268,7 +268,7 @@ class NativeScriptRenderer implements Renderer2 {`
`268`	`268`	`if (NativeScriptDebug.enabled) {`
`269`	`269`	NativeScriptDebug.rendererLog(`NativeScriptRenderer.removeChild child: ${oldChild} parent: ${parent}`);
`270`	`270`	`}`
`271`		`- this.viewUtil.removeChild(parent, oldChild);`
	`271`	`+ this.viewUtil.removeChild(parent ?? oldChild.parentNode, oldChild);`
`272`	`272`	`}`
`273`	`273`	`selectRootElement(selectorOrNode: any, preserveContent?: boolean) {`
`274`	`274`	`if (NativeScriptDebug.enabled) {`