From 09a3b16ed7957a9788b1380bc5db772dcb7155e1 Mon Sep 17 00:00:00 2001 From: Alok Joshi Date: Thu, 23 Jul 2026 12:26:39 +0530 Subject: [PATCH] Nit - follow the single responsibility principle and only make the test_output_csv validate the generated csv file, not the ncu report Signed-off-by: Alok Joshi --- tests/test_profiler.py | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/tests/test_profiler.py b/tests/test_profiler.py index 196bddc..4034687 100644 --- a/tests/test_profiler.py +++ b/tests/test_profiler.py @@ -671,7 +671,7 @@ def output_csv_func(x: int, y: int) -> None: _simple_kernel_impl(x, y, annotation=f"output_csv={output_csv}") # Run the profiling - profile_output = output_csv_func() + output_csv_func() # Check for CSV files based on output_csv value csv_files = [ @@ -689,16 +689,6 @@ def output_csv_func(x: int, y: int) -> None: file_path ), f"CSV file should not exist when output_csv=False: {file_path}" - # NCU report files should always exist regardless of output_csv - ncu_files = [ - f"{output_dir}test_ncu-output-output_csv_func-0.ncu-rep", - f"{output_dir}test_ncu-output-output_csv_func-0.log", - ] - - for file_path in ncu_files: - assert os.path.exists( - file_path - ), f"NCU file should always exist: {file_path}" finally: if os.path.exists(output_dir): shutil.rmtree(output_dir)