Skip to content

THIRD_PARTY_NOTICES names distroless/go v4.0.2 while the image builds on v4.1.1 #210

Description

@lexfrei

THIRD_PARTY_NOTICES.md says the runtime base is nvcr.io/nvidia/distroless/go:v4.0.2 and links the v4.0.2 source index, but Dockerfile.distroless:63 builds on v4.1.1.

The version is hardcoded in tools/generate-notices.sh instead of being read from the Dockerfile the way the rest of that file derives its facts: BASE_SOURCE_URL at line 36, and the base-image sentence at line 579. So when the Dockerfile was bumped the notices kept the old version.

make notices-check can't catch it. It regenerates using the same constant and compares the result against the committed file, so that field is consistent with itself whatever the Dockerfile says.

It matters because it's the base-image source offer: the link points at sources for a version the image no longer ships.

Deriving the version from the Dockerfile would fix it and stop it drifting again on the next bump.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions