NRL-1866 Remove duplicate script & fix broken imports

Author: anjalitrace2-nhs

scripts/seed_nft_tables.py

@@ -11,18 +11,20 @@
 # import json
 import numpy as np
 
-from nrlf.consumer.fhir.r4.model import DocumentReference
 from nrlf.core.constants import (
     CATEGORY_ATTRIBUTES,
     SNOMED_SYSTEM_URL,
     TYPE_ATTRIBUTES,
     TYPE_CATEGORIES,
-    Categories,
-    PointerTypes,
 )
 from nrlf.core.dynamodb.model import DocumentPointer
 from nrlf.core.logger import logger
 from nrlf.tests.data import load_document_reference
+from tests.performance.seed_data_constants import (  # DEFAULT_COUNT_DISTRIBUTIONS,
+    CHECKSUM_WEIGHTS,
+    DEFAULT_CUSTODIAN_DISTRIBUTIONS,
+    DEFAULT_TYPE_DISTRIBUTIONS,
+)
 
 dynamodb = boto3.client("dynamodb")
 resource = boto3.resource("dynamodb")
@@ -31,69 +33,6 @@
 
 DOC_REF_TEMPLATE = load_document_reference("NFT-template")
 
-CHECKSUM_WEIGHTS = [i for i in range(10, 1, -1)]
-
-# These are based on the Nov 7th 2025 pointer stats report
-DEFAULT_TYPE_DISTRIBUTIONS = {
-    "736253002": 65,  # mental health crisis plan
-    "1382601000000107": 5,  # respect form
-    "887701000000100": 15,  # emergency healthcare plan
-    "861421000000109": 5,  # eol care coordination summary
-    "735324008": 5,  # treatment escalation plan
-    "824321000000109": 5,  # summary record
-}
-
-DEFAULT_CUSTODIAN_DISTRIBUTIONS = {
-    "736253002": {
-        "TRPG": 9,
-        "TRHA": 1,
-        "TRRE": 20,
-        "TRAT": 10,
-        "TWR4": 4,
-        "TRKL": 9,
-        "TRW1": 5,
-        "TRH5": 1,
-        "TRP7": 13,
-        "TRWK": 8,
-        "TRQY": 3,
-        "TRV5": 3,
-        "TRJ8": 2,
-        "TRXA": 4,
-        "T11X": 1,
-        "TG6V": 2,
-    },
-    "1382601000000107": {"T8GX8": 3, "TQUY": 2},  # respect form
-    "887701000000100": {
-        "TV1": 1,
-        "TV2": 2,
-        "TV3": 1,
-        "TV4": 1,
-        "TV5": 3,
-        "TV6": 1,
-    },  # emergency healthcare plan
-    "861421000000109": {
-        "TV1": 2,
-        "TV2": 2,
-        "TV3": 1,
-        "TV4": 1,
-        "TV5": 3,
-        "TV6": 1,
-    },  # eol care coordination summary
-    "735324008": {
-        "TV1": 1,
-        "TV2": 1,
-        "TV3": 1,
-        "TV4": 2,
-        "TV5": 2,
-        "TV6": 1,
-    },  # treatment escalation plan
-    "824321000000109": {
-        "TRXT": 1,
-    },  # summary record currently has only one supplier
-}
-
-DEFAULT_COUNT_DISTRIBUTIONS = {"1": 91, "2": 8, "3": 1}
-
 
 class TestNhsNumbersIterator:
     def __iter__(self):
@@ -262,7 +201,7 @@ def _get_pointer_count_poisson_distributions(
 
 
 def _set_up_custodian_iterators(
-    custodian_dists: dict[str, dict[str, int]]
+    custodian_dists: dict[str, dict[str, int]],
 ) -> dict[str, Iterator[str]]:
     custodian_iters: dict[str, Iterator[str]] = {}
     for pointer_type in custodian_dists:

tests/performance/README.md

@@ -50,19 +50,21 @@ make truststore-pull-all ENV=perftest
 You will need to generate pointer permissions the first time performance tests are run in an environment e.g. if the perftest environment is destroyed & recreated.
 
 ```sh
+# In project root
 make generate permissions   # makes a bunch of json permission files for test organisations
 make build  # will take all permissions & create nrlf_permissions.zip file
 
 # apply this new permissions zip file to your environment
 cd ./terraform/infrastructure
-assume test
+assume nhsd-nrlf-test
 make init TF_WORKSPACE_NAME=perftest-1 ENV=perftest
 make ENV=perftest USE_SHARED_RESOURCES=true apply
 ```
 
 #### Generate input files
 
 ```sh
+assume nhsd-nrlf-test
 # creates 2 csv files and a json file
 make perftest-prepare PERFTEST_TABLE_NAME=perftest-baseline
 ```

tests/performance/perftest_environment.py

@@ -5,6 +5,7 @@
 import re
 
 import boto3
+from seed_data_constants import CHECKSUM_WEIGHTS
 
 DYNAMODB = boto3.resource("dynamodb", region_name="eu-west-2")
 
@@ -55,10 +56,6 @@ def extract_consumer_data(output_dir="."):
     print(f"Consumer data written to {out}")  # noqa: T201
 
 
-# Semi-deterministic NHS number generator (duplicated from seed_nft_tables.py)
-CHECKSUM_WEIGHTS = [i for i in range(10, 1, -1)]
-
-
 class TestNhsNumbersIterator:
     def __iter__(self):
         self.first9 = 900000000

tests/performance/producer/delete_permissions.py

@@ -1,7 +1,8 @@
 from pathlib import Path
 
 import fire
-from seed_nft_tables import DEFAULT_CUSTODIAN_DISTRIBUTIONS
+
+from tests.performance.seed_data_constants import DEFAULT_CUSTODIAN_DISTRIBUTIONS
 
 
 def main(permissions_dir="../../dist/nrlf_permissions/K6PerformanceTest"):

tests/performance/producer/generate_distributions.py

@@ -1,8 +1,10 @@
 import json
 from pathlib import Path
 
-# Import the constants from your seed_nft_tables.py
-from seed_nft_tables import DEFAULT_CUSTODIAN_DISTRIBUTIONS, DEFAULT_TYPE_DISTRIBUTIONS
+from tests.performance.seed_data_constants import (
+    DEFAULT_CUSTODIAN_DISTRIBUTIONS,
+    DEFAULT_TYPE_DISTRIBUTIONS,
+)
 
 
 def expand_distribution(dist):

tests/performance/producer/generate_permissions.py

@@ -2,7 +2,8 @@
 from pathlib import Path
 
 import fire
-from seed_nft_tables import DEFAULT_CUSTODIAN_DISTRIBUTIONS
+
+from tests.performance.seed_data_constants import DEFAULT_CUSTODIAN_DISTRIBUTIONS
 
 
 def main(output_dir="../../dist/nrlf_permissions/K6PerformanceTest"):