Skip to content

Commit 59a1f94

Browse files
add project workflow (#160)
* add project workflow * add permissions
1 parent f39074f commit 59a1f94

3 files changed

Lines changed: 87 additions & 16 deletions

File tree

.github/pull_request_template.md

Lines changed: 53 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,32 +1,69 @@
1-
# Description
1+
# PR Summary
22

3-
## Summary
3+
Sci/Tech Reviewer: <!-- SR id, filled by author when ready for review (e.g. @octocat) -->
4+
Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) -->
45

5-
_Briefly describe the feature being introduced._
6+
<!-- To be completed by the developer -->
67

7-
## Changes
8+
<!-- Provide a brief description of the changes in this PR, including any notes
9+
useful for reviewers -->
810

9-
_List the major changes made in this pull request._
11+
<!-- List any linked PRs here
12+
- linked MetOffice/<REPO-NAME>#<pr-number>
13+
-->
1014

11-
## Dependency
15+
<!-- List any blocking PRs or issues to be closed here
16+
- is blocked-by #pr-number
17+
- blocks #pr-number
18+
- closes #issue-number (auto-closes the issue)
19+
- fixes #issue-number (auto-closes the issue)
20+
- is related to #issue-number
21+
-->
1222

13-
_List dependent changes. Can use build-group logic here._
23+
## Code Quality Checklist
1424

15-
## Impact
25+
- [ ] I have performed a self-review of my own code
26+
- [ ] My code follows the project's [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index)
27+
- [ ] Comments have been included that aid understanding and enhance the readability of the code
28+
- [ ] My changes generate no new warnings
29+
- [ ] All automated checks in the CI pipeline have completed successfully
1630

17-
_Discuss any potential impacts this feature may have on existing functionalities._
31+
## Testing
1832

19-
## Issues addressed
33+
- [ ] This change has been tested appropriately (please describe)
2034

21-
Resolves
35+
## Security Considerations
2236

23-
_List issue(s) related to this PR._
37+
- [ ] I have reviewed my changes for potential security issues
38+
- [ ] Sensitive data is properly handled (if applicable)
39+
- [ ] Authentication and authorisation are properly implemented (if applicable)
2440

25-
## Coordinated merge
41+
## AI Assistance and Attribution
2642

27-
_Specify any coordinated merges here._
43+
- [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels)
2844

45+
<!-- If AI has been used, please provide more details here -->
2946

30-
## Checklist
47+
# Sci/Tech Review
48+
49+
<!-- To be completed by the Sci/Tech Reviewer -->
50+
<!-- May be skipped for trivial tickets -->
51+
52+
- [ ] I understand this area of code and the changes being added
53+
- [ ] The proposed changes correspond to the pull request description
54+
- [ ] Documentation is sufficient (do documentation papers need updating)
55+
- [ ] Sufficient testing has been completed
56+
57+
(_Please alert the code reviewer via a tag when you have approved the SR_)
58+
59+
# Code Review
60+
61+
<!-- To be completed by the Code Reviewer -->
62+
63+
- [ ] All dependencies have been resolved
64+
- [ ] Related Issues have been properly linked and addressed
65+
- [ ] Code quality standards have been met
66+
- [ ] Tests are adequate and have passed
67+
- [ ] Security considerations have been addressed
68+
- [ ] Performance impact is acceptable
3169

32-
- [ ] I have performed a self-review of my own changes
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Track Review Project
2+
3+
on:
4+
workflow_run:
5+
workflows: [Trigger Review Project]
6+
types:
7+
- completed
8+
9+
permissions:
10+
actions: read
11+
contents: read
12+
pull-requests: write
13+
14+
jobs:
15+
track_review_project:
16+
uses: MetOffice/growss/.github/workflows/track-review-project.yaml@main
17+
secrets: inherit
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
name: Trigger Review Project
2+
3+
on:
4+
pull_request_target:
5+
types: ["opened", "synchronize", "reopened", "edited", "review_requested", "review_request_removed"]
6+
pull_request_review:
7+
pull_request_review_comment:
8+
9+
permissions:
10+
actions: read
11+
contents: read
12+
pull-requests: write
13+
14+
jobs:
15+
trigger_project_workflow:
16+
uses: MetOffice/growss/.github/workflows/trigger-project-workflow.yaml@main
17+
secrets: inherit

0 commit comments

Comments
 (0)