|
1 | | -# Description |
| 1 | +# PR Summary |
2 | 2 |
|
3 | | -## Summary |
| 3 | +Sci/Tech Reviewer: <!-- SR id, filled by author when ready for review (e.g. @octocat) --> |
| 4 | +Code Reviewer: <!-- CR id, filled by SSD/CCD (e.g. @octocat) --> |
4 | 5 |
|
5 | | -_Briefly describe the feature being introduced._ |
| 6 | +<!-- To be completed by the developer --> |
6 | 7 |
|
7 | | -## Changes |
| 8 | +<!-- Provide a brief description of the changes in this PR, including any notes |
| 9 | + useful for reviewers --> |
8 | 10 |
|
9 | | -_List the major changes made in this pull request._ |
| 11 | +<!-- List any linked PRs here |
| 12 | +- linked MetOffice/<REPO-NAME>#<pr-number> |
| 13 | +--> |
10 | 14 |
|
11 | | -## Dependency |
| 15 | +<!-- List any blocking PRs or issues to be closed here |
| 16 | +- is blocked-by #pr-number |
| 17 | +- blocks #pr-number |
| 18 | +- closes #issue-number (auto-closes the issue) |
| 19 | +- fixes #issue-number (auto-closes the issue) |
| 20 | +- is related to #issue-number |
| 21 | +--> |
12 | 22 |
|
13 | | -_List dependent changes. Can use build-group logic here._ |
| 23 | +## Code Quality Checklist |
14 | 24 |
|
15 | | -## Impact |
| 25 | +- [ ] I have performed a self-review of my own code |
| 26 | +- [ ] My code follows the project's [style guidelines](https://metoffice.github.io/lfric_core/how_to_contribute/index.html#how-to-contribute-index) |
| 27 | +- [ ] Comments have been included that aid understanding and enhance the readability of the code |
| 28 | +- [ ] My changes generate no new warnings |
| 29 | +- [ ] All automated checks in the CI pipeline have completed successfully |
16 | 30 |
|
17 | | -_Discuss any potential impacts this feature may have on existing functionalities._ |
| 31 | +## Testing |
18 | 32 |
|
19 | | -## Issues addressed |
| 33 | +- [ ] This change has been tested appropriately (please describe) |
20 | 34 |
|
21 | | -Resolves |
| 35 | +## Security Considerations |
22 | 36 |
|
23 | | -_List issue(s) related to this PR._ |
| 37 | +- [ ] I have reviewed my changes for potential security issues |
| 38 | +- [ ] Sensitive data is properly handled (if applicable) |
| 39 | +- [ ] Authentication and authorisation are properly implemented (if applicable) |
24 | 40 |
|
25 | | -## Coordinated merge |
| 41 | +## AI Assistance and Attribution |
26 | 42 |
|
27 | | -_Specify any coordinated merges here._ |
| 43 | +- [ ] Some of the content of this change has been produced with the assistance of _Generative AI tool name_ (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the [Simulation Systems AI policy](https://metoffice.github.io/simulation-systems/FurtherDetails/ai.html) (including attribution labels) |
28 | 44 |
|
| 45 | +<!-- If AI has been used, please provide more details here --> |
29 | 46 |
|
30 | | -## Checklist |
| 47 | +# Sci/Tech Review |
| 48 | + |
| 49 | +<!-- To be completed by the Sci/Tech Reviewer --> |
| 50 | +<!-- May be skipped for trivial tickets --> |
| 51 | + |
| 52 | +- [ ] I understand this area of code and the changes being added |
| 53 | +- [ ] The proposed changes correspond to the pull request description |
| 54 | +- [ ] Documentation is sufficient (do documentation papers need updating) |
| 55 | +- [ ] Sufficient testing has been completed |
| 56 | + |
| 57 | +(_Please alert the code reviewer via a tag when you have approved the SR_) |
| 58 | + |
| 59 | +# Code Review |
| 60 | + |
| 61 | +<!-- To be completed by the Code Reviewer --> |
| 62 | + |
| 63 | +- [ ] All dependencies have been resolved |
| 64 | +- [ ] Related Issues have been properly linked and addressed |
| 65 | +- [ ] Code quality standards have been met |
| 66 | +- [ ] Tests are adequate and have passed |
| 67 | +- [ ] Security considerations have been addressed |
| 68 | +- [ ] Performance impact is acceptable |
31 | 69 |
|
32 | | -- [ ] I have performed a self-review of my own changes |
|
0 commit comments