Request Body Logging failed

[fiurthorn]

Logging request body doesn't work for me because the body was already read at the time of logging.
So the body should be read before other handlers can read it.

like:

b, _ := io.ReadAll(r.Body)
r.Body = io.NopCloser(bytes.NewBuffer(b))
...
param := LogFormatterParams{
    Request:     r,
    RequestBody: b,
    isTerm:      isTerm,
}

[erudenko]

I believe it was an issue in early releases. Could you provide some code examples?

[fiurthorn]

Always get an empty body

r = httplog.LoggerWithFormatter(httplog.FullFormatterWithRequestAndResponseHeadersAndBody)(r)

===
 EMPTY BODY 
===

[fiurthorn]

first mistake httplog.FullFormatterWithRequestAndResponseHeadersAndBody do not set CaptureBodyto true.
But that makes no sens to me since it is named withBody.

second, I always have to capture the body before the

	middleware := func(next http.Handler) http.Handler {
		return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
			...
*			body, _ := io.ReadAll(r.Body)
*			r.Body = io.NopCloser(bytes.NewBuffer(bytes.Clone(body)))
			...
			wr := NewWriter(w, conf.CaptureBody)
			next.ServeHTTP(wr, r)
			...
			if !skip {
				r.Header = maskHeaderKeys(r.Header.Clone(), hideHeaderKeys)

				param := LogFormatterParams{
					Request:     r,
*					RequestBody: body,
					isTerm:      isTerm,
				}
			...

last but not least, that do not capture the response body from from the http.FileServer.

[fiurthorn]

after some debuging, found that the ReadFrom method, do not capture the body, since it write to rw.ResponseWriter not to the own Writer. so the body will not captured.

func (rw *responseWriter) ReadFrom(r io.Reader) (n int64, err error) {
	if !rw.Written() {
		// The status will be StatusOK if WriteHeader has not been called yet
		rw.WriteHeader(http.StatusOK)
	}
*	n, err = io.Copy(rw.ResponseWriter, r)
	rw.size += int(n)
	return
}