Skip to content

Commit 561ce8d

Browse files
committed
Convert remaining positional args to to keyword args
1 parent 9f2a305 commit 561ce8d

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

app/models/lexical_query_builder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
class LexicalQueryBuilder
2-
def build(params, fulltext = false)
2+
def build(params, fulltext: false)
33
{
44
bool: {
55
should: multisearch(params),

app/models/opensearch.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ def query
6161
LexicalQueryBuilder.new
6262
end
6363

64-
builder.build(@params, @fulltext)
64+
builder.build(@params, fulltext: @fulltext)
6565
end
6666

6767
def sort_builder

test/models/lexical_query_builder_test.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -71,14 +71,14 @@ class LexicalQueryBuilderTest < ActiveSupport::TestCase
7171
builder = LexicalQueryBuilder.new
7272
params = { q: 'this' }
7373

74-
assert(builder.build(params, true).to_json.include?('"fields":["alternate_titles","call_numbers","citation","contents","contributors.value","dates.value","edition","funding_information.*","identifiers.value","languages","locations.value","notes.value","numbering","publication_information","subjects.value","summary","title","fulltext"]'))
74+
assert(builder.build(params, fulltext: true).to_json.include?('"fields":["alternate_titles","call_numbers","citation","contents","contributors.value","dates.value","edition","funding_information.*","identifiers.value","languages","locations.value","notes.value","numbering","publication_information","subjects.value","summary","title","fulltext"]'))
7575
end
7676

7777
test 'fulltext is not included by default' do
7878
builder = LexicalQueryBuilder.new
7979
params = { q: 'this' }
8080

81-
assert(builder.build(params, false).to_json.include?('"fields":["alternate_titles","call_numbers","citation","contents","contributors.value","dates.value","edition","funding_information.*","identifiers.value","languages","locations.value","notes.value","numbering","publication_information","subjects.value","summary","title"]'))
81+
assert(builder.build(params, fulltext: false).to_json.include?('"fields":["alternate_titles","call_numbers","citation","contents","contributors.value","dates.value","edition","funding_information.*","identifiers.value","languages","locations.value","notes.value","numbering","publication_information","subjects.value","summary","title"]'))
8282
end
8383

8484
test 'can search by geopoint' do

0 commit comments

Comments
 (0)