fix toString result for Intl.Collator, Intl.DateTimeFormat, Intl.NumberFormat, and Intl.v8BreakIterator

rbri · rbri · commit c85b10572766 · 2026-04-16T17:35:31.000+02:00
fix v8BreakIterator ctor to accept langage-region
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
@@ -8,6 +8,12 @@
 
     <body>
         <release version="5.0.0" date="April 31, 2026" description="jdk17, Bugfixes">
+            <action type="fix" dev="rbri">
+                Fix toString result for Intl.Collator, Intl.DateTimeFormat, Intl.NumberFormat, and Intl.v8BreakIterator.
+            </action>
+            <action type="fix" dev="rbri">
+                Fix v8BreakIterator ctor to accept langage-region.
+            </action>
             <action type="fix" dev="Lai Quang Duong">
                 Fix DomNode.insertBefore(DomNode) to dissolve DocumentFragment into its children before insertion.
             </action>
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/Collator.java b/src/main/java/org/htmlunit/javascript/host/intl/Collator.java
@@ -70,4 +70,12 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
         format.setPrototype(((FunctionObject) ctorObj).getClassPrototype());
         return format;
     }
+
+    @Override
+    public Object getDefaultValue(final Class<?> hint) {
+        if (String.class.equals(hint) || hint == null) {
+            return "[object Intl.Collator]";
+        }
+        return super.getDefaultValue(hint);
+    }
 }
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/DateTimeFormat.java b/src/main/java/org/htmlunit/javascript/host/intl/DateTimeFormat.java
@@ -324,6 +324,14 @@ public static Scriptable supportedLocalesOf(final Scriptable localesArgument, fi
         return Intl.supportedLocalesOf(localesArgument);
     }
 
+    @Override
+    public Object getDefaultValue(final Class<?> hint) {
+        if (String.class.equals(hint) || hint == null) {
+            return "[object Intl.DateTimeFormat]";
+        }
+        return super.getDefaultValue(hint);
+    }
+
     /**
      * Helper.
      */
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/NumberFormat.java b/src/main/java/org/htmlunit/javascript/host/intl/NumberFormat.java
@@ -228,6 +228,14 @@ public static Scriptable supportedLocalesOf(final Scriptable localesArgument, fi
         return Intl.supportedLocalesOf(localesArgument);
     }
 
+    @Override
+    public Object getDefaultValue(final Class<?> hint) {
+        if (String.class.equals(hint) || hint == null) {
+            return "[object Intl.NumberFormat]";
+        }
+        return super.getDefaultValue(hint);
+    }
+
     /**
      * Helper.
      */
diff --git a/src/main/java/org/htmlunit/javascript/host/intl/V8BreakIterator.java b/src/main/java/org/htmlunit/javascript/host/intl/V8BreakIterator.java
@@ -63,11 +63,11 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,
             final Object locales = args[0];
             if (locales instanceof NativeArray array) {
                 if (array.getLength() != 0) {
-                    locale = new Locale.Builder().setLanguage(array.get(0).toString()).build();
+                    locale = new Locale.Builder().setLanguageTag(array.get(0).toString()).build();
                 }
             }
             else if (locales instanceof String) {
-                locale = new Locale.Builder().setLanguage(locales.toString()).build();
+                locale = new Locale.Builder().setLanguageTag(locales.toString()).build();
             }
             else if (!JavaScriptEngine.isUndefined(locales)) {
                 throw JavaScriptEngine.throwAsScriptRuntimeEx(
@@ -108,7 +108,10 @@ else if ("sentence".equals(obj)) {
      */
     @Override
     public Object getDefaultValue(final Class<?> hint) {
-        return getClassName();
+        if (String.class.equals(hint) || hint == null) {
+            return "[object Object]";
+        }
+        return super.getDefaultValue(hint);
     }
 
     /**
diff --git a/src/test/java/org/htmlunit/general/HostClassNameTest.java b/src/test/java/org/htmlunit/general/HostClassNameTest.java
@@ -4390,6 +4390,17 @@ public void intl_NumberFormat() throws Exception {
         test("Intl.NumberFormat");
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts(DEFAULT = "undefined",
+            CHROME = "function v8BreakIterator() { [native code] }",
+            EDGE = "function v8BreakIterator() { [native code] }")
+    public void intl_v8BreakIterator() throws Exception {
+        test("Intl.v8BreakIterator");
+    }
+
     /**
      * @throws Exception if the test fails
      */
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/IntlTest.java b/src/test/java/org/htmlunit/javascript/host/intl/IntlTest.java
@@ -16,6 +16,7 @@
 
 import org.htmlunit.WebDriverTestCase;
 import org.htmlunit.junit.annotation.Alerts;
+import org.htmlunit.junit.annotation.HtmlUnitNYI;
 import org.junit.jupiter.api.Test;
 
 /**
@@ -93,6 +94,11 @@ public void locale() throws Exception {
     @Alerts({"de",
              "function Locale() { [native code] }",
              "TypeError"})
+    @HtmlUnitNYI(
+            CHROME = {"de", "function Locale() { [native code] }", "[object Locale]"},
+            EDGE = {"de", "function Locale() { [native code] }", "[object Locale]"},
+            FF = {"de", "function Locale() { [native code] }", "[object Locale]"},
+            FF_ESR = {"de", "function Locale() { [native code] }", "[object Locale]"})
     public void localeCtor() throws Exception {
         testCtor("new Intl.Locale('de')");
     }
diff --git a/src/test/java/org/htmlunit/javascript/host/intl/V8BreakIteratorTest.java b/src/test/java/org/htmlunit/javascript/host/intl/V8BreakIteratorTest.java
@@ -59,6 +59,32 @@ public void v8BreakIterator() throws Exception {
         loadPageVerifyTitle2(html);
     }
 
+    /**
+     * @throws Exception if the test fails
+     */
+    @Test
+    @Alerts(DEFAULT = "no support",
+            CHROME = "true",
+            EDGE = "true")
+    public void v8BreakIterator2() throws Exception {
+        final String html = DOCTYPE_HTML
+                + "<html><head>\n"
+                + "<script>\n"
+                + LOG_TITLE_FUNCTION
+                + "  function test() {\n"
+                + "    if (window.Intl && window.Intl.v8BreakIterator) {\n"
+                + "      var iterator = Intl.v8BreakIterator('de-DE');\n"
+                + "      log(iterator instanceof Intl.v8BreakIterator);\n"
+                + "    } else { log('no support'); }\n"
+                + "  }\n"
+                + "</script>\n"
+                + "</head>\n"
+                + "<body onload='test()'>\n"
+                + "</body></html>";
+
+        loadPageVerifyTitle2(html);
+    }
+
     /**
      * @throws Exception if the test fails
      */

Original file line number	Diff line number	Diff line change
`@@ -70,4 +70,12 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,`
`70`	`70`	`format.setPrototype(((FunctionObject) ctorObj).getClassPrototype());`
`71`	`71`	`return format;`
`72`	`72`	`}`
	`73`	`+`
	`74`	`+ @Override`
	`75`	`+ public Object getDefaultValue(final Class<?> hint) {`
	`76`	`+ if (String.class.equals(hint) \|\| hint == null) {`
	`77`	`+ return "[object Intl.Collator]";`
	`78`	`+ }`
	`79`	`+ return super.getDefaultValue(hint);`
	`80`	`+ }`
`73`	`81`	`}`
Original file line number	Diff line number	Diff line change
`@@ -63,11 +63,11 @@ public static Scriptable jsConstructor(final Context cx, final Scriptable scope,`
`63`	`63`	`final Object locales = args[0];`
`64`	`64`	`if (locales instanceof NativeArray array) {`
`65`	`65`	`if (array.getLength() != 0) {`
`66`		`- locale = new Locale.Builder().setLanguage(array.get(0).toString()).build();`
	`66`	`+ locale = new Locale.Builder().setLanguageTag(array.get(0).toString()).build();`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`else if (locales instanceof String) {`
`70`		`- locale = new Locale.Builder().setLanguage(locales.toString()).build();`
	`70`	`+ locale = new Locale.Builder().setLanguageTag(locales.toString()).build();`
`71`	`71`	`}`
`72`	`72`	`else if (!JavaScriptEngine.isUndefined(locales)) {`
`73`	`73`	`throw JavaScriptEngine.throwAsScriptRuntimeEx(`
`@@ -108,7 +108,10 @@ else if ("sentence".equals(obj)) {`
`108`	`108`	`*/`
`109`	`109`	`@Override`
`110`	`110`	`public Object getDefaultValue(final Class<?> hint) {`
`111`		`- return getClassName();`
	`111`	`+ if (String.class.equals(hint) \|\| hint == null) {`
	`112`	`+ return "[object Object]";`
	`113`	`+ }`
	`114`	`+ return super.getDefaultValue(hint);`
`112`	`115`	`}`
`113`	`116`
`114`	`117`	`/**`