Address code review feedback: fix typos, improve error message, optimize binary accumulation

- Rename closeIncommingSession -> closeIncomingSession in interface and all callers
- Fix 'WebSockt' typos in Javadoc
- Update error message to accurately describe supported content types
- Use ByteArrayOutputStream for efficient binary message accumulation

Agent-Logs-Url: https://github.com/HtmlUnit/htmlunit/sessions/b3db8ccb-ee0a-436b-8c39-85fd25db4747

Co-authored-by: rbri <2544132+rbri@users.noreply.github.com>

Author: Copilot

javac.20260412_170050.args

@@ -421,7 +421,7 @@ public void close() throws IOException {
     public void close(final Object code, final Object reason) {
         if (readyState_ != CLOSED) {
             try {
-                webSocketImpl_.closeIncommingSession();
+                webSocketImpl_.closeIncomingSession();
             }
             catch (final Throwable e) {
                 LOG.error("WS close error - incomingSession_.close() failed", e);

src/main/java/org/htmlunit/javascript/host/WebSocket.java

@@ -14,6 +14,7 @@
  */
 package org.htmlunit.websocket;
 
+import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.net.CookieHandler;
 import java.net.URI;
@@ -135,7 +136,7 @@ else if (content instanceof ByteBuffer buffer) {
             }
             else {
                 throw new IllegalStateException(
-                        "Not Yet Implemented: WebSocket.send() was used to send non-string value");
+                        "Unsupported content type for WebSocket.send(): expected String or ByteBuffer");
             }
         }
         catch (final IllegalStateException e) {
@@ -150,7 +151,7 @@ else if (content instanceof ByteBuffer buffer) {
      * {@inheritDoc}
      */
     @Override
-    public void closeIncommingSession() {
+    public void closeIncomingSession() {
         if (incomingSession_ != null) {
             incomingSession_.sendClose(java.net.http.WebSocket.NORMAL_CLOSURE, "").join();
         }
@@ -239,7 +240,7 @@ public void put(final URI uri,
     private class JdkWebSocketListenerImpl implements java.net.http.WebSocket.Listener {
 
         private StringBuilder textAccumulator_;
-        private ByteBuffer binaryAccumulator_;
+        private ByteArrayOutputStream binaryAccumulator_;
 
         JdkWebSocketListenerImpl() {
             super();
@@ -274,22 +275,20 @@ public CompletionStage<?> onText(final java.net.http.WebSocket webSocket,
         public CompletionStage<?> onBinary(final java.net.http.WebSocket webSocket,
                 final ByteBuffer data, final boolean last) {
             if (binaryAccumulator_ == null) {
-                binaryAccumulator_ = ByteBuffer.allocate(data.remaining());
-                binaryAccumulator_.put(data);
+                binaryAccumulator_ = new ByteArrayOutputStream();
+            }
+            if (data.hasArray()) {
+                binaryAccumulator_.write(data.array(),
+                        data.arrayOffset() + data.position(), data.remaining());
             }
             else {
-                final ByteBuffer newBuffer = ByteBuffer.allocate(
-                        binaryAccumulator_.position() + data.remaining());
-                binaryAccumulator_.flip();
-                newBuffer.put(binaryAccumulator_);
-                newBuffer.put(data);
-                binaryAccumulator_ = newBuffer;
+                final byte[] temp = new byte[data.remaining()];
+                data.get(temp);
+                binaryAccumulator_.write(temp, 0, temp.length);
             }
 
             if (last) {
-                binaryAccumulator_.flip();
-                final byte[] bytes = new byte[binaryAccumulator_.remaining()];
-                binaryAccumulator_.get(bytes);
+                final byte[] bytes = binaryAccumulator_.toByteArray();
                 binaryAccumulator_ = null;
                 listener_.onWebSocketBinary(bytes, 0, bytes.length);
             }

src/main/java/org/htmlunit/websocket/JdkWebSocketAdapter.java

@@ -18,7 +18,7 @@
 import java.net.URI;
 
 /**
- * Helper to have no direct dependency to the WebSockt client
+ * Helper to have no direct dependency to the WebSocket client
  * implementation used by HtmlUnit.
  *
  * @author Ronald Brill
@@ -49,11 +49,11 @@ public interface WebSocketAdapter {
     void send(Object content) throws IOException;
 
     /**
-     * Close the incomming session.
+     * Close the incoming session.
      *
      * @throws Exception in case of error
      */
-    void closeIncommingSession() throws Exception;
+    void closeIncomingSession() throws Exception;
 
     /**
      * Close the outgoing session.

src/main/java/org/htmlunit/websocket/WebSocketAdapter.java

@@ -15,7 +15,7 @@
 package org.htmlunit.websocket;
 
 /**
- * Helper to have no direct dependency to the WebSockt client
+ * Helper to have no direct dependency to the WebSocket client
  * implementation used by HtmlUnit.
  *
  * @author Ronald Brill