From 07b0c21e29a635158d78b063457cf01948c6125c Mon Sep 17 00:00:00 2001 From: nutzboi Date: Mon, 9 Feb 2026 20:27:52 +0200 Subject: [PATCH] Sanitize illegal characters from download filename. prevent /installaddon failing (especially on windows) when basename contains characters that are illegal in popular filesystems. --- src/states_screens/dialogs/addons_pack.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/states_screens/dialogs/addons_pack.cpp b/src/states_screens/dialogs/addons_pack.cpp index a6aedb0d859..93a8536dfcb 100644 --- a/src/states_screens/dialogs/addons_pack.cpp +++ b/src/states_screens/dialogs/addons_pack.cpp @@ -82,6 +82,14 @@ class AddonsPackRequest : public HTTPRequest url.find("http://") != std::string::npos) { setURL(url); + std::string illegal_chars = "/\\:*\"?<>|"; + for(unsigned i = 0; i < m_filename.size(); i++) + { + if(illegal_chars.find(m_filename[i]) != std::string::npos) + { + m_filename[i] = '-'; + } + } setDownloadAssetsRequest(true); } else