Skip to content

Commit 25b2dc9

Browse files
committed
fix(storagecontrol): resolve PR review comments
[Generated-by: AI]
1 parent 27ed93e commit 25b2dc9

2 files changed

Lines changed: 18 additions & 6 deletions

File tree

‎storagecontrol/managed_folder_list.py‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,9 @@ def list_managed_folders(bucket_name: str = "your-bucket-name") -> None:
3939
# The storage bucket path uses the global access pattern,
4040
# in which the "_" denotes this bucket exists in the global namespace.
4141
GLOBAL_NAMESPACE_PATTERN = "_"
42-
bucket_resource_name = f"projects/{GLOBAL_NAMESPACE_PATTERN}/buckets/{bucket_name}"
42+
bucket_resource_name = (
43+
f"projects/{GLOBAL_NAMESPACE_PATTERN}/buckets/{bucket_name}"
44+
)
4345

4446
managed_folders = client.list_managed_folders(parent=bucket_resource_name)
4547

‎storagecontrol/snippets_test.py‎

Lines changed: 15 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ def test_folder_create_get_list_rename_delete(
3838
folder_name = uuid_name
3939

4040
# Test create folder
41-
create_folder.create_folder(bucket_name=bucket_name, folder_name=folder_name)
41+
create_folder.create_folder(
42+
bucket_name=bucket_name, folder_name=folder_name
43+
)
4244
out, _ = capsys.readouterr()
4345
assert folder_name in out
4446

@@ -78,9 +80,13 @@ def test_delete_folder_recursive(
7880
child_folder = f"parent-{uuid_name}/child-{uuid_name}"
7981

8082
# Create parent folder
81-
create_folder.create_folder(bucket_name=bucket_name, folder_name=parent_folder)
83+
create_folder.create_folder(
84+
bucket_name=bucket_name, folder_name=parent_folder
85+
)
8286
# Create child folder
83-
create_folder.create_folder(bucket_name=bucket_name, folder_name=child_folder)
87+
create_folder.create_folder(
88+
bucket_name=bucket_name, folder_name=child_folder
89+
)
8490

8591
# Call delete folder recursive
8692
delete_folder_recursive.delete_folder_recursive(
@@ -95,10 +101,14 @@ def test_delete_folder_recursive(
95101

96102
# Verify folders are deleted (NotFound exceptions)
97103
with pytest.raises(exceptions.NotFound):
98-
get_folder.get_folder(bucket_name=bucket_name, folder_name=parent_folder)
104+
get_folder.get_folder(
105+
bucket_name=bucket_name, folder_name=parent_folder
106+
)
99107

100108
with pytest.raises(exceptions.NotFound):
101-
get_folder.get_folder(bucket_name=bucket_name, folder_name=child_folder)
109+
get_folder.get_folder(
110+
bucket_name=bucket_name, folder_name=child_folder
111+
)
102112

103113

104114
# === Managed Folders === #

0 commit comments

Comments
 (0)