Skip to content

Commit b53a69a

Browse files
authored
Merge pull request #119 from GetStream/kmp/stream-results
Migrate to Stream Log 1.3.0 and support stream-result-call for KMP
2 parents f73d6b5 + 8692112 commit b53a69a

5 files changed

Lines changed: 28 additions & 36 deletions

File tree

app/build.gradle.kts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,5 +67,4 @@ dependencies {
6767

6868
// logger
6969
implementation(libs.stream.log)
70-
implementation(libs.stream.log.android)
7170
}

app/src/main/kotlin/io/getstream/resultdemo/StreamResultApp.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
package io.getstream.resultdemo
1717

1818
import android.app.Application
19-
import io.getstream.log.android.AndroidStreamLogger
19+
import io.getstream.log.AndroidStreamLogger
2020

2121
class StreamResultApp : Application() {
2222

gradle/libs.versions.toml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
[versions]
2-
streamLog = "1.1.4"
2+
streamLog = "1.3.1"
33
androidGradlePlugin = "8.6.1"
44
androidxActivity = "1.4.0"
55
androidxAppCompat = "1.7.0"
@@ -31,7 +31,6 @@ mockitoKotlin = "4.1.0"
3131

3232
[libraries]
3333
stream-log = { group = "io.getstream", name = "stream-log", version.ref = "streamLog" }
34-
stream-log-android = { group = "io.getstream", name = "stream-log-android", version.ref = "streamLog" }
3534
androidx-appcompat = { group = "androidx.appcompat", name = "appcompat", version.ref = "androidxAppCompat" }
3635
androidx-annotation = { group = "androidx.annotation", name = "annotation", version.ref = "androidxAnnotation" }
3736
androidx-material = { module = "com.google.android.material:material", version.ref = "androidxMaterial" }

stream-result-call/build.gradle.kts

Lines changed: 26 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -40,18 +40,17 @@ mavenPublishing {
4040
}
4141

4242
kotlin {
43-
// TODO: Migrate Stream Log to KMP
44-
// listOf(
45-
// iosX64(),
46-
// iosArm64(),
47-
// iosSimulatorArm64(),
48-
// macosArm64(),
49-
// macosX64(),
50-
// ).forEach {
51-
// it.binaries.framework {
52-
// baseName = "common"
53-
// }
54-
// }
43+
listOf(
44+
iosX64(),
45+
iosArm64(),
46+
iosSimulatorArm64(),
47+
macosArm64(),
48+
macosX64(),
49+
).forEach {
50+
it.binaries.framework {
51+
baseName = "common"
52+
}
53+
}
5554

5655
androidTarget {
5756
publishLibraryVariants("release")
@@ -69,8 +68,12 @@ kotlin {
6968
all {
7069
languageSettings.optIn("kotlin.contracts.ExperimentalContracts")
7170
}
72-
val commonMain by getting {
71+
commonMain {
7372
dependencies {
73+
api(project(":stream-result"))
74+
75+
implementation(libs.kotlinx.coroutines)
76+
implementation(libs.stream.log)
7477
}
7578
}
7679
}
@@ -91,18 +94,13 @@ android {
9194
targetCompatibility = JavaVersion.VERSION_11
9295
}
9396
}
94-
95-
dependencies {
96-
api(project(":stream-result"))
97-
98-
implementation(libs.kotlinx.coroutines)
99-
implementation(libs.stream.log)
100-
testImplementation(libs.testing.kluent)
101-
testImplementation(libs.testing.coroutines.test)
102-
testImplementation(libs.testing.mockito)
103-
testImplementation(libs.testing.mockito.kotlin)
104-
testImplementation(libs.testing.mockito.kotlin)
105-
testImplementation(libs.androidx.test.junit)
106-
testImplementation("org.junit.jupiter:junit-jupiter-api:5.11.0")
107-
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.11.0")
108-
}
97+
dependencies {
98+
testImplementation(libs.testing.kluent)
99+
testImplementation(libs.testing.coroutines.test)
100+
testImplementation(libs.testing.mockito)
101+
testImplementation(libs.testing.mockito.kotlin)
102+
testImplementation(libs.testing.mockito.kotlin)
103+
testImplementation(libs.androidx.test.junit)
104+
testImplementation("org.junit.jupiter:junit-jupiter-api:5.11.0")
105+
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:5.11.0")
106+
}

stream-result/build.gradle.kts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,6 @@ kotlin {
6767
all {
6868
languageSettings.optIn("kotlin.contracts.ExperimentalContracts")
6969
}
70-
val commonMain by getting {
71-
dependencies {
72-
}
73-
}
7470
}
7571

7672
explicitApi()

0 commit comments

Comments
 (0)