Commit 986b81e
Serha
fix: Restore logger in native client wrappers to fix AccessViolationException (v4.0.1-beta)
CRITICAL HOTFIX for v4.0.0-beta regression
Root Cause:
- v4.0.0-beta removed StderrLogReceiver from Historical, Live, and LiveBlocking client wrappers
- Passed nullptr to databento-cpp constructors instead of logger instance
- databento-cpp tried to log messages without null-checking the logger pointer
- Result: AccessViolationException crashes when logging attempted
Symptoms:
- Fatal crashes on ALL Historical API queries
- Crashes on Live and LiveBlocking subscriptions
- Particularly common when databento-cpp tried to log warnings or errors
- Multiple user reports immediately after v4.0.0-beta release
Fixes Applied:
- historical_client_wrapper.cpp: Restored log_receiver member and initialization
- live_client_wrapper.cpp: Restored log_receiver and SetLogReceiver() call
- live_blocking_wrapper.cpp: Restored log_receiver and SetLogReceiver() call
- Rebuilt databento_native.dll with all fixes
Changes:
- src/Databento.Native/src/historical_client_wrapper.cpp
- src/Databento.Native/src/live_client_wrapper.cpp
- src/Databento.Native/src/live_blocking_wrapper.cpp
- src/Databento.Interop/runtimes/win-x64/native/databento_native.dll
- src/Databento.Client/Databento.Client.csproj (version 4.0.0-beta → 4.0.1-beta)
- CHANGELOG.md (added v4.0.1-beta entry)
Testing:
- TestsScratchpad.Internal now runs successfully
- Logger output visible: "[Databento WARNING]" messages appear correctly
- No crashes on queries that previously failed
All users on v4.0.0-beta should upgrade immediately.1 parent 74f4b54 commit 986b81e
6 files changed
Lines changed: 32 additions & 8 deletions
File tree
- src
- Databento.Client
- Databento.Interop/runtimes/win-x64/native
- Databento.Native/src
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
8 | 22 | | |
9 | 23 | | |
10 | 24 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
12 | | - | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
Binary file not shown.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
| 33 | + | |
33 | 34 | | |
34 | 35 | | |
35 | | - | |
| 36 | + | |
| 37 | + | |
36 | 38 | | |
37 | | - | |
| 39 | + | |
38 | 40 | | |
39 | 41 | | |
40 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
| 26 | + | |
26 | 27 | | |
27 | 28 | | |
28 | 29 | | |
29 | 30 | | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
| 34 | + | |
| 35 | + | |
34 | 36 | | |
35 | 37 | | |
36 | 38 | | |
| |||
39 | 41 | | |
40 | 42 | | |
41 | 43 | | |
| 44 | + | |
42 | 45 | | |
43 | 46 | | |
44 | 47 | | |
| |||
51 | 54 | | |
52 | 55 | | |
53 | 56 | | |
54 | | - | |
| 57 | + | |
| 58 | + | |
55 | 59 | | |
56 | 60 | | |
57 | 61 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| 30 | + | |
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
| |||
41 | 42 | | |
42 | 43 | | |
43 | 44 | | |
44 | | - | |
| 45 | + | |
| 46 | + | |
45 | 47 | | |
46 | 48 | | |
47 | 49 | | |
| |||
50 | 52 | | |
51 | 53 | | |
52 | 54 | | |
| 55 | + | |
53 | 56 | | |
54 | 57 | | |
55 | 58 | | |
| |||
67 | 70 | | |
68 | 71 | | |
69 | 72 | | |
70 | | - | |
| 73 | + | |
| 74 | + | |
71 | 75 | | |
72 | 76 | | |
73 | 77 | | |
| |||
0 commit comments