Skip to content

Commit c3cd8f9

Browse files
authored
Merge pull request #110 from ASU-CodeDevils/dev
Dev
2 parents 8928e07 + 678f0be commit c3cd8f9

5 files changed

Lines changed: 68 additions & 32 deletions

File tree

.github/CONTRIBUTING.MD

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,23 @@ Some example branch names:
5959
```fix/110/fix-org-link ```
6060

6161

62-
#### Commits and Pull Requests
62+
#### Commits
63+
64+
To the best of your ability, please try to keep the commits to your Issue Branch as few as possible. If there end up being a lot of commits on your branch, please squash them before you create your Pull Request.
65+
66+
Your Commits do not have any requirements for their naming convention, other than being vaguely relevant to the actions taken. They need not be anything more than a short description of your changes
67+
68+
#### Pull Requests
6369

6470
After you have finished working on an Issue and you have a finished version of your code, commit it to your branch, and create a Pull Request to merge your Issue Branch to `dev`.
6571

66-
To the best of your ability, please try to keep the commits to your Issue Branch as few as possible. If there end up being a lot of commits on your branch, please squash them before you create your Pull Request.
72+
Your Pull Requests have some requirements for documentation. They must include:
73+
- An explanation of the changes you made.
74+
- For issues tagged "simple", this need not be very detailed, but just a note of what you did.
75+
- For issues with no complexity tag, give a reasonable explanation for the changes you made. It should be comprehensive. You are welcome to mention anything interesting about your solution.
76+
- For issues tagged "complex", you MUST explain why you made any choices that you did for how you approached the issue, in addition to a reasonable explanation for your changes.
77+
- You must link the issue that you are working on at the end of the Pull Request. To do this, you must type a '#' character, and follow it with the Issue Number. This will indicate on the Issue itself that this Pull Request resolves it. For example, if you are working issue 99, you need to end your Pull Request with '#99'
78+
6779

6880
#### Main vs Dev Branch
6981

.github/ISSUE_GUIDE.MD

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
# Before you create an Issue...
2+
3+
We're glad that you're here to report an issue with our project. Please keep in mind, that many problems or inconsistencies with our code is known by our team. Our Project Leads release issues to our contributors to keep consistent work available to our teams. While outside issues are allowed, they will not be counted as contribution unless it is approved by the Project Lead.
4+
5+
## Reach out to the Project Lead
6+
7+
The best way to get your issue addressed as a contributor is to reach out to your Project Lead in your team channels. You may often get automatic assignment to an issue that you identify ahead of an issue's posting, and a Project Lead may grant you extra points for having identified it.
8+
9+
As an outside reviewer, you may create an issue for the project, but you MUST tag your issue with the tag "non-PL", or it will be closed.
10+
11+
# Template and Requirements
12+
13+
When creating an issue as an outside reviewer, please follow one of the following guides depending on your type of issue:
14+
15+
## Type 1:
16+
17+
Your issue is a Type 1 issue if you are simply noticing and reporting a problem with the project as a user. Experienced bugs, broken things, etc.
18+
19+
- Issue Name: ```(USER PROBLEM) [Description of your issue]```
20+
- Issue Description:
21+
Your issue description MUST contain a detailed explanation of the issue. If there are any visual elements involved, screenshots or screen recordings of an issue replication MUST be included.
22+
23+
**DO NOT** include any reference to the code with this issue type. If you experience this issue, and have found a way to fix it, please leave it for our contributors to work out how they may debug the issue themselves. If you would like to share your solution, please message the Project Lead.
24+
- Labels: Your Issue must have the "non-PL" tag.
25+
26+
## Type 2:
27+
28+
Your issue is a Type 2 issue if you are reviewing the code as an outside reviewer and have a suggestion for how the code can be improved.
29+
30+
- Issue Name: ```(REVIEWER SUGGESTION) [Description of your suggestion]```
31+
- Issue Description:
32+
Your issue description MUST contain the following:
33+
- A detailed description of the section of code needing improvement.
34+
- A reasonable explanation as to why it needs improvement.
35+
- Suggestions for improvement WITHOUT implementing the solution yourself.
36+
37+
**DO NOT** include your own work in this issue type. You simply need to point out a flaw in the code and tell us why you believe it needs to be improved and in what way.
38+
- Labels: Your Issue must have the "non-PL" tag.

README.md

Lines changed: 13 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -4,50 +4,35 @@
44

55
This is the official repository for CodeDevils' website. It's built using the [Next.js](https://nextjs.org) framework, [Tailwind CSS](https://tailwindcss.com/), and [TypeScript](https://www.typescriptlang.org/). The website is hosted on [Vercel](https://vercel.com).
66

7-
## Why are there `.js` files in here?
87

9-
As per [T3-Axiom #3](https://github.com/t3-oss/create-t3-app/tree/next#3-typesafety-isnt-optional), we take typesafety as a first class citizen. Unfortunately, not all frameworks and plugins support TypeScript which means some of the configuration files have to be `.js` files.
8+
## The Project
109

11-
We try to emphasize that these files are javascript for a reason, by explicitly declaring its type (`cjs` or `mjs`) depending on what's supported by the library it is used by. Also, all the `js` files in this project are still typechecked using a `@ts-check` comment at the top.
10+
Packages:
1211

13-
## Contributing (Getting Started)
12+
- [PNPM](https://pnpm.io/installation)
13+
- [Node.js](https://nodejs.org/en/download/)
14+
- [Git](https://git-scm.com/downloads)
1415

15-
1. Pre-requisites:
16+
Installing the project:
1617

17-
- [PNPM](https://pnpm.io/installation)
18-
- [Node.js](https://nodejs.org/en/download/)
19-
- [Git](https://git-scm.com/downloads)
20-
21-
2. Clone the repository:
18+
1. Clone the repository:
2219
```sh
2320
git clone https://github.com/ASU-CodeDevils/codedevils.org.git
2421
```
25-
3. Install the dependencies:
22+
2. Install the dependencies:
2623
```sh
2724
pnpm install
2825
```
29-
4. Run the development server:
26+
3. Run the development server:
3027
```sh
3128
pnpm dev
3229
```
3330

34-
## Contributing (Code Style)
35-
36-
This project uses [Prettier](https://prettier.io/) and [ESLint](https://eslint.org/) to enforce code style. Please make sure to run `pnpm format`, then `pnpm lint` before committing your changes.
37-
38-
## Contributing (Commit Messages)
39-
40-
This project uses [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) to enforce a consistent commit message format. Please make sure to follow the commit message format when making changes.
41-
42-
```
43-
<type>[optional scope]: <description>
44-
45-
[optional body]
31+
## Contributing
4632

47-
[optional footer(s)]
33+
[Check out our Contribution Guide here!](https://github.com/ASU-CodeDevils/codedevils.org/blob/main/.github/CONTRIBUTING.MD)
4834

49-
```
5035

51-
## Contributing (Pull Requests)
36+
## Creating Issues
5237

53-
Please make sure to follow the pull request template when creating a pull request.
38+
[Check out our Issue Creation Guide here!](https://github.com/ASU-CodeDevils/codedevils.org/blob/main/.github/ISSUE_GUIDE.MD)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"start": "next start",
1010
"lint": "next lint",
1111
"format": "prettier --write ."
12-
},
12+
},
1313
"dependencies": {
1414
"@next/bundle-analyzer": "^14.0.4",
1515
"@react-three/drei": "^9.102.5",

src/app/(main)/(routes)/projects/content.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,8 @@ const projectTeams = {
3535
academy: [['pita'],
3636
],
3737
website: [ ['pita'],
38-
['David Fales']
38+
['Juliana Bush'],
39+
['Ella Rushing']
3940
],
4041
gamedev: [ ['remi'],
4142
['Autumn O'],

0 commit comments

Comments
 (0)