Skip to content

WrappedSiteCalculator: Consider type stability and GPU memory barriers #318

@jameskermode

Description

@jameskermode

From PR #313 review (non-blocking comment by @cortner):

The WrappedSiteCalculator struct has some design considerations for future work:

  1. co_ps field: Currently not supported, but left as placeholder for committee parameters
  2. GPU memory barriers: Need to discuss how to best implement without breaking GPU memory barriers
  3. Type stability: The co_ps::Any field breaks type stability. Questions to consider:
    • How important is type stability for exporting?
    • If unimportant, model, ps, st could all be Any for more flexibility (e.g., allow updating st with preallocated memory)
    • Calculator then acts as a function barrier to keep type instability at the outermost layer

Reference: #313 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions