Merge pull request #115 from 1012839419a-alt/1012839419a-alt/butterflyray

chore: clear repository diagnostics and restore CI contracts

Author: 2233admin

.agents/skills/bmad-advanced-elicitation/scripts/pick_methods.py

@@ -170,23 +170,59 @@ def fmt_rows(rows: list[dict], as_json: bool) -> str:
 
 def main(argv: list[str] | None = None) -> int:
     if hasattr(sys.stdout, "reconfigure"):
-        sys.stdout.reconfigure(encoding="utf-8")  # catalog rows contain →; don't die on locale code pages
-    p = argparse.ArgumentParser(description=__doc__, formatter_class=argparse.RawDescriptionHelpFormatter)
-    p.add_argument("--file", type=Path, default=DEFAULT_FILE, help="method CSV (default: sibling assets/methods.csv)")
-    p.add_argument("--extra", help="additional methods: a JSON array literal or a path to a JSON file")
-    p.add_argument("--json", action="store_true", help="emit structured JSON instead of lean text")
+        sys.stdout.reconfigure(
+            encoding="utf-8"
+        )  # catalog rows contain →; don't die on locale code pages
+    p = argparse.ArgumentParser(
+        description=__doc__,
+        formatter_class=argparse.RawDescriptionHelpFormatter,
+    )
+    p.add_argument(
+        "--file",
+        type=Path,
+        default=DEFAULT_FILE,
+        help="method CSV (default: sibling assets/methods.csv)",
+    )
+    p.add_argument(
+        "--json",
+        action="store_true",
+        help="emit structured JSON instead of lean text",
+    )
     sub = p.add_subparsers(dest="cmd", required=True)
     sub.add_parser("categories", help="list category names + counts")
-    pl = sub.add_parser("list", help="the index for chosen categories (needs --category or --all)")
-    pl.add_argument("--category", action="append", help="filter to a category (repeatable)")
-    pl.add_argument("--all", action="store_true", help="dump the entire catalog (deliberate; large)")
+    pl = sub.add_parser(
+        "list",
+        help="the index for chosen categories (needs --category or --all)",
+    )
+    pl.add_argument(
+        "--category",
+        action="append",
+        help="filter to a category (repeatable)",
+    )
+    pl.add_argument(
+        "--all",
+        action="store_true",
+        help="dump the entire catalog (deliberate; large)",
+    )
     ps = sub.add_parser("show", help="full row for each named method")
     ps.add_argument("names", nargs="+", help="method names or nums")
     pr = sub.add_parser("random", help="draw methods at random")
     pr.add_argument("-n", type=int, default=1, help="how many (default 1)")
-    pr.add_argument("--category", action="append", help="restrict to a category (repeatable)")
-    pr.add_argument("--exclude", action="append", help="method name to skip (repeatable) — e.g. already shown")
-    pr.add_argument("--spread", action="store_true", help="force category diversity across the draw")
+    pr.add_argument(
+        "--category",
+        action="append",
+        help="restrict to a category (repeatable)",
+    )
+    pr.add_argument(
+        "--exclude",
+        action="append",
+        help="method name to skip (repeatable) — e.g. already shown",
+    )
+    pr.add_argument(
+        "--spread",
+        action="store_true",
+        help="force category diversity across the draw",
+    )
     args = p.parse_args(argv)
 
     if not args.file.is_file():
@@ -205,8 +241,9 @@ def main(argv: list[str] | None = None) -> int:
     elif args.cmd == "list":
         if not args.category and not args.all:
             print(
-                "error: `list` needs --category (one or more) — or --all to dump the whole "
-                "catalog on purpose. Use `categories` for the cheap map, or `random` to draw blind.",
+                "error: `list` needs --category (one or more) — or --all to dump "
+                "the whole catalog on purpose. Use `categories` for the cheap map, "
+                "or `random` to draw blind.",
                 file=sys.stderr,
             )
             return 2

.agents/skills/bmad-advanced-elicitation/scripts/tests/test_pick_methods.py

@@ -17,13 +17,18 @@
 sys.path.insert(0, str(Path(__file__).resolve().parent.parent))
 import pick_methods  # noqa: E402
 
-CSV = """num,category,method_name,description,output_pattern
-1,risk,Pre-mortem Analysis,Imagine future failure then work backwards,failure → causes → prevention
-2,risk,Assumption Audit,List and stress-test every assumption,list → rate → stress-test
-3,core,First Principles Analysis,Rebuild from fundamental truths,assumptions → truths → new approach
-4,core,Socratic Questioning,Targeted questions reveal hidden assumptions,questions → revelations → understanding
-5,creative,SCAMPER Method,Seven creativity lenses,S→C→A→M→P→E→R
-"""
+CSV = (
+    "num,category,method_name,description,output_pattern\n"
+    "1,risk,Pre-mortem Analysis,Imagine future failure then work backwards,"
+    "failure → causes → prevention\n"
+    "2,risk,Assumption Audit,List and stress-test every assumption,"
+    "list → rate → stress-test\n"
+    "3,core,First Principles Analysis,Rebuild from fundamental truths,"
+    "assumptions → truths → new approach\n"
+    "4,core,Socratic Questioning,Targeted questions reveal hidden assumptions,"
+    "questions → revelations → understanding\n"
+    "5,creative,SCAMPER Method,Seven creativity lenses,S→C→A→M→P→E→R\n"
+)
 
 EXTRA = [
     {

.agents/skills/bmad-architecture/scripts/lint_spine.py

@@ -129,7 +129,10 @@ def find_ad_issues(body: str, offset: int) -> list[dict]:
             findings.append({
                 "category": "ad_id",
                 "severity": "high",
-                "detail": f"AD-{num} is non-monotonic (follows AD-{prev}); ids must ascend and never renumber",
+                "detail": (
+                    f"AD-{num} is non-monotonic (follows AD-{prev}); "
+                    "ids must ascend and never renumber"
+                ),
                 "location": loc,
             })
         prev = num if prev is None else max(prev, num)
@@ -228,20 +231,33 @@ def lint(text: str) -> dict:
 
 
 def main(argv: list[str] | None = None) -> int:
-    ap = argparse.ArgumentParser(description="Lint an architecture spine for mechanical integrity.")
-    ap.add_argument("--workspace", required=True, help="run folder containing ARCHITECTURE-SPINE.md")
+    ap = argparse.ArgumentParser(
+        description="Lint an architecture spine for mechanical integrity."
+    )
+    ap.add_argument(
+        "--workspace", required=True, help="run folder containing ARCHITECTURE-SPINE.md"
+    )
     ap.add_argument("-o", "--output", help="write JSON here instead of stdout")
     args = ap.parse_args(argv)
-
     spine_path = Path(args.workspace) / SPINE
+
     if not spine_path.exists():
-        result = {"ok": False, "error": f"{spine_path} not found", "findings": [], "total_findings": 0}
+        result = {
+            "ok": False,
+            "error": f"{spine_path} not found",
+            "findings": [],
+            "total_findings": 0,
+        }
     else:
         try:
             text = spine_path.read_text(encoding="utf-8")
         except (OSError, UnicodeDecodeError) as e:
-            # honor the "exit code is always 0" contract: a read/decode failure travels in JSON
-            result = {"ok": False, "error": f"could not read {spine_path}: {e}", "findings": [], "total_findings": 0}
+            result = {
+                "ok": False,
+                "error": f"could not read {spine_path}: {e}",
+                "findings": [],
+                "total_findings": 0,
+            }
         else:
             result = lint(text)
 

.agents/skills/bmad-architecture/scripts/tests/test_lint_spine.py

@@ -119,7 +119,11 @@ def test_unpinned_dep_caught():
 def test_placeholder_version_caught():
     text = CLEAN.replace("| fastapi | 0.115 |", "| fastapi | {pin} |")
     result = lint_spine.lint(text)
-    assert any(f["category"] == "version_pin" and "fastapi" in f["detail"] for f in result["findings"])
+    assert any(
+        f["category"] == "version_pin"
+        and "fastapi" in f["detail"]
+        for f in result["findings"]
+    )
 
 
 def test_no_stack_section_ok():
@@ -146,12 +150,19 @@ def test_template_token_is_low_severity():
     # mechanical pass stays near-zero false-positive
     text = CLEAN.replace("single write path", "{decision}")
     result = lint_spine.lint(text)
-    toks = [f for f in result["findings"] if f["category"] == "placeholder" and "template token" in f["detail"]]
+    toks = [
+        f
+        for f in result["findings"]
+        if f["category"] == "placeholder" and "template token" in f["detail"]
+    ]
     assert toks and all(f["severity"] == "low" for f in toks)
 
 
 def test_no_frontmatter_body_still_scanned():
-    text = "## Invariants\n\n### AD-1 — x\n\n- **Binds:** all\n- **Prevents:** drift\n- **Rule:** TBD\n"
+    text = (
+        "## Invariants\n\n### AD-1 — x\n\n"
+        "- **Binds:** all\n- **Prevents:** drift\n- **Rule:** TBD\n"
+    )
     result = lint_spine.lint(text)
     assert "placeholder" in cats(result)  # TBD caught even with no frontmatter
 
@@ -161,7 +172,9 @@ def test_frontmatter_value_with_dashes_not_truncated():
     text = ("---\nname: 'x'\nscope: 'phase 1 --- phase 2'\n---\n\n"
             "## Stack\n\n| Name | Version |\n| --- | --- |\n| fastapi |  |\n")
     result = lint_spine.lint(text)
-    assert any(f["category"] == "version_pin" for f in result["findings"])  # read past the inline ---
+    assert any(
+        f["category"] == "version_pin" for f in result["findings"]
+    )  # read past the inline ---
 
 
 def test_ad_heading_in_fence_not_counted():
@@ -247,15 +260,25 @@ def test_frontmatter_unfilled_token_caught():
     # an unfilled {scope}/{paradigm}/{date} in frontmatter is part of the contract and must lint
     text = "---\nname: 'x'\nscope: '{what this spine governs}'\n---\n\n## Invariants\n"
     result = lint_spine.lint(text)
-    fm = [f for f in result["findings"] if f["category"] == "placeholder" and "frontmatter" in f["detail"]]
-    assert fm and any("template token" in f["detail"] for f in fm)
+    fm = [
+        f
+        for f in result["findings"]
+        if f["category"] == "placeholder" and "frontmatter" in f["detail"]
+    ]
+    assert fm and any(
+        "template token" in f["detail"] for f in fm
+    )
 
 
 def test_frontmatter_tbd_caught():
     text = "---\nname: 'x'\nstatus: TBD\n---\n\n## Invariants\n"
     result = lint_spine.lint(text)
-    assert any(f["category"] == "placeholder" and "frontmatter" in f["detail"] and "TBD" in f["detail"]
-               for f in result["findings"])
+    assert any(
+        f["category"] == "placeholder"
+        and "frontmatter" in f["detail"]
+        and "TBD" in f["detail"]
+        for f in result["findings"]
+    )
 
 
 def test_unreadable_spine_returns_error_not_crash(tmp_path, capsys):